Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mono 5.18 #1444

Merged
merged 28 commits into from
Apr 8, 2019
Merged

Use mono 5.18 #1444

merged 28 commits into from
Apr 8, 2019

Conversation

rchande
Copy link

@rchande rchande commented Apr 3, 2019

No description provided.

@rchande
Copy link
Author

rchande commented Apr 3, 2019

@filipw Some of my builds are having an issue similar to the sqlite thing you fixed a while ago. Any idea what we should do?

@filipw
Copy link
Member

filipw commented Apr 4, 2019

it looks similar indeed, I will have a look

@filipw
Copy link
Member

filipw commented Apr 4, 2019

although now it seems like you managed to move past it and it's now failing at GetReferenceNearestTargetFrameworkTask

@filipw
Copy link
Member

filipw commented Apr 6, 2019

you still need to bump the Mono version in here https://github.com/OmniSharp/omnisharp-roslyn/blob/master/azure-pipelines.yml#L34
but great job making all the loose pieces work 😅

@@ -51,6 +51,10 @@
<assemblyIdentity name="System.Composition.TypedParts" publicKeyToken="b03f5f7f11d50a3a" culture="neutral"/>
<bindingRedirect oldVersion="0.0.0.0-1.0.31.0" newVersion="1.0.31.0"/>
</dependentAssembly>
<dependentAssembly>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file (and other binding redirects files) have MsBuild redirects to 15.1.0.0, I think they should be updated too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried updating this and binding failed; opened assemblies from msbuild 16 and the version is still 15.1...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. of course it is... 🤯

@rchande
Copy link
Author

rchande commented Apr 8, 2019

@filipw It's actually weirder than that. The Azure Devops Mac machines only have mono 5.16. If I change it to 5.18, they can't find any mono (it actually works by just concatenating your mono version with a mono base path) and they don't have 5.18. I'm inclined to just no-ope the Mac builds in order to get this unblocked...

Ravi Chande and others added 2 commits April 8, 2019 07:28
@rchande
Copy link
Author

rchande commented Apr 8, 2019

@filipw Actually, I think it's simple enough to just install mono...maybe

@rchande rchande closed this Apr 8, 2019
@rchande rchande reopened this Apr 8, 2019
@rchande rchande closed this Apr 8, 2019
@rchande rchande reopened this Apr 8, 2019
@rchande rchande closed this Apr 8, 2019
@rchande rchande reopened this Apr 8, 2019
@rchande rchande merged commit 1c2dcf3 into OmniSharp:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants