Fixed issue with "go to implementation" and symbol overrides #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where "find implementation" OmniSharp would not find symbol overrides in child types. We were missing the look up of overrides on the symbols returned from
SymbolFinder.FindImplementationsAsync
.Consider the following:
In Visual Studio, trying to go to implementation of
Hi()
, from the interface declaration, would find bothBar.Hi()
andBaz.Hi()
. However, OmniSharp would find onlyBar.Hi()
.This is with the fix applied: