Feature/script supersede lower versions #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Feb 2, 2018
src/OmniSharp.Script/ScriptHelper.cs
Outdated
| var referencesSupersedeLowerVersionsProperty = typeof(CompilationOptions).GetProperty(ReferencesSupersedeLowerVersionsProperty, BindingFlags.Instance | BindingFlags.NonPublic); | ||
| if (referencesSupersedeLowerVersionsProperty != null) | ||
| { | ||
| referencesSupersedeLowerVersionsProperty?.SetValue(compilationOptions, true); |
There was a problem hiding this comment.
Is the ?. needed after checking for null above?
There was a problem hiding this comment.
Technically the if could be removed couldn't it?
|
I will merge this now 😀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicting assembly versions in scripting are typically resolved via identity comparer, which we already use.
However, scripting scenarios in Roslyn additionally set a special flag in the ReferenceManager to enable additional tie-breaking behavior in case of conflicting references. This flag is propagated from the compilation options, and is always implicitly injected for script compilations.
To mirror 1:1 the runtime behavior of scripts, we should ensure the same flag is set at tooling level (at the moment we have it set to to☹️ ).
falsewhich can lead to edge case false-positive intellisense errors). Unfortunately the flag is internal so it's set with reflection (along with a few other things we do with reflection in script tooling