simplified the filtering logic for internals visible to

OmniSharp · Aug 19, 2020 · 4e70b5c · 4e70b5c
1 parent 72f179a
commit 4e70b5c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionService.cs b/src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionService.cs
@@ -152,8 +152,6 @@ public async Task<CompletionResponse> Handle(CompletionRequest request)
             for (int i = 0; i < completions.Items.Length; i++)
             {
                 var completion = completions.Items[i];
-                if (!completion.IsVisible()) continue;
-
                 var commitCharacters = buildCommitCharacters(completions, completion.Rules.CommitCharacterRules, triggerCharactersBuilder);
 
                 var insertTextFormat = InsertTextFormat.PlainText;
@@ -168,7 +166,7 @@ public async Task<CompletionResponse> Handle(CompletionRequest request)
                             // span, only assembly keys at the end if they exist.
                             {
                                 // if the completion is for the hidden Misc files project, skip it
-
+                                if (completion.DisplayText == Configuration.OmniSharpMiscProjectName) continue;
                                 CompletionChange change = await completionService.GetChangeAsync(document, completion);
                                 Debug.Assert(typedSpan == change.TextChange.Span);
                                 insertText = change.TextChange.NewText!;

diff --git a/src/OmniSharp.Roslyn.CSharp/Services/Intellisense/CompletionItemExtensions.cs b/src/OmniSharp.Roslyn.CSharp/Services/Intellisense/CompletionItemExtensions.cs
@@ -103,17 +103,5 @@ public static AutoCompleteResponse ToAutoCompleteResponse(this CompletionItem it
 
             return response;
         }
-
-        public static bool IsVisible(this CompletionItem item)
-        {
-            switch (item.GetProviderName())
-            {
-                case InternalsVisibleToCompletionProvider:
-                    if (item.DisplayText == Configuration.OmniSharpMiscProjectName) return false;
-                    break;
-            }
-
-            return true;
-        }
     }
 }