Merge pull request #1588 from filipw/bugfix/windowsonly

run the complex analyzer test only on Windows
OmniSharp · Aug 20, 2019 · 42fe801 · 42fe801
2 parents dacc49a + 78f3c7d
commit 42fe801
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/tests/OmniSharp.MSBuild.Tests/ProjectWithComplexAnalyzersTests.cs b/tests/OmniSharp.MSBuild.Tests/ProjectWithComplexAnalyzersTests.cs
@@ -12,8 +12,8 @@ public ProjectWithComplexAnalyzersTests(ITestOutputHelper output) : base(output)
         {
         }
 
-        // possible thread starvation on Linux when running in Azure DevOps
-        [ConditionalFact(typeof(NotOnLinux))]
+        // possible thread starvation on *nix when running in Azure DevOps
+        [ConditionalFact(typeof(WindowsOnly))]
         public async Task CanLoadComplexAnalyzers()
         {
             using (var testProject = await TestAssets.Instance.GetTestProjectAsync("ProjectWithComplexAnalyzers"))

diff --git a/tests/TestUtility/ConditionalFactAttribute.cs b/tests/TestUtility/ConditionalFactAttribute.cs
@@ -54,10 +54,4 @@ public class WindowsOnly : SkipCondition
         public override bool ShouldSkip => !PlatformHelper.IsWindows;
         public override string SkipReason => "Can only be run on Windows";
     }
-
-    public class NotOnLinux : SkipCondition
-    {
-        public override bool ShouldSkip => RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
-        public override string SkipReason => "Cannot be run on Linux";
-    }
 }