Skip to content

Add npm to CI build - #1049

Merged
JoeRobich merged 3 commits into
OmniSharp:masterfrom
manandre:npm-ci
Oct 3, 2023
Merged

Add npm to CI build#1049
JoeRobich merged 3 commits into
OmniSharp:masterfrom
manandre:npm-ci

Conversation

@manandre

@manandre manandre commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Should avoid introducing breaking changes in the vscode-testextension project and int its npm dependencies in particular.

@github-actions github-actions Bot added this to the v0.19.10 milestone Oct 2, 2023
@JoeRobich

JoeRobich commented Oct 2, 2023

Copy link
Copy Markdown
Member

So, for C# extension integration tests we needed to setup a virtual display for our linux leg and pass the id in the DISPLAY environment variable. See https://github.com/dotnet/vscode-csharp/blob/ed352248c09fa57cfb2c2c0b04874fd122a26538/.github/workflows/ci.yml#L18

JoeRobich
JoeRobich approved these changes Oct 3, 2023
View reviewed changes

@JoeRobich JoeRobich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manandre!

@JoeRobich
JoeRobich merged commit 00adbe3 into OmniSharp:master Oct 3, 2023
@github-actions github-actions Bot added the mysterious We forgot to label this label Oct 3, 2023
@manandre
manandre deleted the npm-ci branch October 3, 2023 19:21
This was referenced Oct 7, 2026
Open
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

mysterious We forgot to label this

Projects

None yet

Milestone

v0.19.10

Development

Successfully merging this pull request may close these issues.

2 participants

@manandre @JoeRobich