Adding webp, tiff, bmp to allowed_extensions list in imageai/Detection/__init__.py#816
Open
santokalayil wants to merge 5 commits intoOlafenwaMoses:masterfrom
Open
Adding webp, tiff, bmp to allowed_extensions list in imageai/Detection/__init__.py#816santokalayil wants to merge 5 commits intoOlafenwaMoses:masterfrom
webp, tiff, bmp to allowed_extensions list in imageai/Detection/__init__.py#816santokalayil wants to merge 5 commits intoOlafenwaMoses:masterfrom
Conversation
Allowed extensions in opencv read list were `["jpg", "jpeg", "png"]`. `.webp` extension also also can be read by opencv. Therefore adding `webp` to the allowed_extension list.
Update __init__.py
|
Is it possible to add BMP and TIFF too? OpenCV appears to support them as well. |
Author
Yes. Let me check them first. if those extensions are supporting. will add them as well. |
Allowed extensions in opencv read list were ["jpg", "jpeg", "png"]. webp, bmp, tiff extensions also can be read by opencv. Therefore adding webp to the allowed_extension list.
santokalayil
changed the title
webp to allowed_extensions list in imageai/Detection/__init__.pywebp, tiff, bmp to allowed_extensions list in imageai/Detection/__init__.py
Author
|
The extensions |
santokalayil
commented
Jun 7, 2023
Author
santokalayil
left a comment
santokalayil
left a comment
There was a problem hiding this comment.
please check once the new changes and approve if these changes are fine.
Author
|
any updates on this change? |
Owner
|
@santokalayil can you add test cases for this change by
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowed extensions in opencv read list were ["jpg", "jpeg", "png"]. .webp extension also also can be read by opencv. Therefore adding webp to the allowed_extension list.