Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in case of update after adding new language #36

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Fix in case of update after adding new language #36

merged 4 commits into from
Sep 17, 2023

Conversation

cdigruttola
Copy link

@cdigruttola cdigruttola commented Aug 28, 2023 •
edited
Loading

This PR is to fix the issue Oksydan/falcon#267

Oksydan
Oksydan requested changes Sep 11, 2023
View reviewed changes
Copy link
Owner

@Oksydan Oksydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedback

src/Form/DataHandler/ImageSliderFormDataHandler.php Outdated Show resolved Hide resolved
src/Form/DataHandler/ImageSliderFormDataHandler.php Outdated Show resolved Hide resolved
@Oksydan
Copy link
Owner

Oksydan commented Sep 11, 2023

Please run ./vendor/bin/php-cs-fixer fix to fix cs fixer errors.

@Oksydan
Copy link
Owner

Oksydan commented Sep 17, 2023

Hi @cdigruttola,

LGTM, merging.
Thank you for your contribution.

@Oksydan Oksydan merged commit 222c1aa into Oksydan:develop Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oksydan Oksydan Oksydan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdigruttola @Oksydan