Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multi-line error messages from require #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle multi-line error messages from require #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Handle multi-line error messages from require 
Since Node.js 12 the "MODULE_NOT_FOUND" error thrown by `require` has a "require stack" appended to its message. This change in behavior results in a message being printed to stderr for example when "config.development.local.json" does not exist.
  • Loading branch information
@maxtruxa
maxtruxa authored May 27, 2019
commit a393660fdb3bd6cbb2ecd159b818ab6ec46ce200
2 changes: 1 addition & 1 deletion lib/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function(path, _, optimist, callsite, is_path_absolute, get_set) {
}
catch(err) {
if ( err.code === 'MODULE_NOT_FOUND'
&& err.message.slice(-file_path.length-1, -1) === file_path) {
&& err.message.split('\n', 1)[0].slice(-file_path.length-1, -1) === file_path) {
// we tried to import an non-existing file
// swallow the error, this is expected.
}
Expand Down