perf(sme): add separate env for SME OAuth #11776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLdragon
requested review from
KennethBWSong,
yuqizhou77,
nliu-ms,
Alive-Fish,
jayzhang,
xzf0587 and
LongOddCode
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11776 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 530 530
Lines 32453 32456 +3
Branches 6294 6292 -2
=======================================
+ Hits 28701 28704 +3
Misses 1817 1817
Partials 1935 1935
|
KennethBWSong
approved these changes
Jun 6, 2024
huimiu
approved these changes
Jun 6, 2024
yuqizhou77
approved these changes
Jun 6, 2024
LongOddCode
approved these changes
Jun 6, 2024
jayzhang
reviewed
Jun 6, 2024
| @@ -62,6 +62,10 @@ export function isCopilotAuthEnabled(): boolean { | |||
| return featureFlagManager.getBooleanValue(FeatureFlags.CopilotAuth); | |||
| } | |||
|
|
|||
| export function isSMEOAuthEnabled(): boolean { | |||
There was a problem hiding this comment.
Suggest to use unified global feature flag manager directly: featureFlagManager.getBooleanValue(FeatureFlags.SMEOAuth)
There was a problem hiding this comment.
As discussed, we plan to update it in another PR
jayzhang
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.