-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(sme): add separate env for SME OAuth #11776
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11776 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 530 530
Lines 32453 32456 +3
Branches 6294 6292 -2
=======================================
+ Hits 28701 28704 +3
Misses 1817 1817
Partials 1935 1935
|
@@ -62,6 +62,10 @@ export function isCopilotAuthEnabled(): boolean { | |||
return featureFlagManager.getBooleanValue(FeatureFlags.CopilotAuth); | |||
} | |||
|
|||
export function isSMEOAuthEnabled(): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to use unified global feature flag manager directly: featureFlagManager.getBooleanValue(FeatureFlags.SMEOAuth)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we plan to update it in another PR
No description provided.