Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate manifest #11566

Merged
merged 7 commits into from
May 13, 2024
Merged

feat: validate manifest #11566

merged 7 commits into from
May 13, 2024

Conversation

yuqizhou77
Copy link
Contributor

@yuqizhou77 yuqizhou77 commented May 9, 2024

Feature 27957104: Add validation for GPT related schemas

Print errors of all manifest
image

  • validate plugin manifest and declarative manifest as well as Teams manifest when "validate manifest".
  • include "ajv-formats" to verify email. uri

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 91.54229% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 88.22%. Comparing base (7fc6b78) to head (b4fbc44).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/5.8.0   #11566      +/-   ##
=================================================
+ Coverage          88.21%   88.22%   +0.01%     
=================================================
  Files                536      536              
  Lines              32204    32377     +173     
  Branches            6320     6221      -99     
=================================================
+ Hits               28408    28564     +156     
- Misses              1875     1879       +4     
- Partials            1921     1934      +13     
Files Coverage Δ
.../src/component/driver/teamsApp/createAppPackage.ts 91.91% <100.00%> (-0.28%) ⬇️
...c/component/driver/teamsApp/utils/ManifestUtils.ts 68.20% <100.00%> (-0.72%) ⬇️
...onent/driver/teamsApp/utils/PluginManifestUtils.ts 93.58% <100.00%> (+6.74%) ⬆️
...e/src/component/driver/teamsApp/utils/telemetry.ts 100.00% <100.00%> (ø)
...-core/src/component/driver/teamsApp/utils/utils.ts 86.32% <100.00%> (+1.41%) ⬆️
packages/spec-parser/src/constants.ts 100.00% <100.00%> (ø)
packages/spec-parser/src/manifestUpdater.ts 93.68% <ø> (ø)
...t/driver/teamsApp/utils/CopilotGptManifestUtils.ts 95.00% <95.58%> (+1.06%) ⬆️
.../fx-core/src/component/driver/teamsApp/validate.ts 86.25% <80.28%> (-7.95%) ⬇️

@yuqizhou77 yuqizhou77 force-pushed the yuqzho/validate-manifest branch 2 times, most recently from 5974643 to 7f35b56 Compare May 10, 2024 16:19
refactor: more

feat: template update

refactor: url

refactor: more

refactor: more

refactor: more

refactor: more

refactor: more
refactor: minor
refactor: more

test: ut1
test: ut

test: ut

refactor: more

test: ut

test: ut

test: ut

test: ut

test: ut

test: ut
@MSFT-yiz MSFT-yiz merged commit fca6a78 into release/5.8.0 May 13, 2024
26 checks passed
@MSFT-yiz MSFT-yiz deleted the yuqzho/validate-manifest branch May 13, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants