-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate manifest #11566
Merged
Merged
feat: validate manifest #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/5.8.0 #11566 +/- ##
=================================================
+ Coverage 88.21% 88.22% +0.01%
=================================================
Files 536 536
Lines 32204 32377 +173
Branches 6320 6221 -99
=================================================
+ Hits 28408 28564 +156
- Misses 1875 1879 +4
- Partials 1921 1934 +13
|
packages/fx-core/src/component/driver/teamsApp/utils/CopilotGptManifestUtils.ts
Fixed
Show fixed
Hide fixed
packages/fx-core/src/component/driver/teamsApp/utils/CopilotGptManifestUtils.ts
Fixed
Show fixed
Hide fixed
yuqizhou77
force-pushed
the
yuqzho/validate-manifest
branch
2 times, most recently
from
May 10, 2024 16:19
5974643
to
7f35b56
Compare
refactor: more feat: template update refactor: url refactor: more refactor: more refactor: more refactor: more refactor: more
refactor: minor
refactor: more test: ut1
yuqizhou77
force-pushed
the
yuqzho/validate-manifest
branch
from
May 10, 2024 16:50
7f35b56
to
43b57f1
Compare
yuqizhou77
force-pushed
the
yuqzho/validate-manifest
branch
from
May 11, 2024 08:14
d78d576
to
2573741
Compare
yuqizhou77
requested review from
hund030,
eriolchan,
huimiu,
KennethBWSong,
SLdragon,
jayzhang,
nliu-ms,
anchenyi,
timngmsft,
sffamily,
therealjohn and
supkasar
as code owners
May 13, 2024 01:06
huimiu
approved these changes
May 13, 2024
nliu-ms
approved these changes
May 13, 2024
jayzhang
approved these changes
May 13, 2024
SLdragon
approved these changes
May 13, 2024
sffamily
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature 27957104: Add validation for GPT related schemas
Print errors of all manifest