perf(oauth): update suffix for oauth in spec parser #11468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11468 +/- ##
========================================
Coverage 87.80% 87.80%
========================================
Files 496 496
Lines 29744 29744
Branches 5777 5922 +145
========================================
Hits 26118 26118
Misses 1778 1778
Partials 1848 1848
|
SLdragon
approved these changes
Apr 25, 2024
SLdragon
reviewed
Apr 25, 2024
| apiKey: "REGISTRATION_ID", | ||
| oauth2: "CONFIGURATION_ID", | ||
| http: "REGISTRATION_ID", | ||
| openIdConnect: "REGISTRATION_ID", |
There was a problem hiding this comment.
Question: why add openIdConnect? Seems no plan to support it in the future
There was a problem hiding this comment.
I add all supported schema in OpenAPIv3 interface to avoid return undefined/throw error if we support this and forget to update here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.