Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: manifest fix #11266

Merged
merged 4 commits into from
Apr 7, 2024
Merged

refactor: manifest fix #11266

merged 4 commits into from
Apr 7, 2024

Conversation

yuqizhou77
Copy link
Contributor

@yuqizhou77 yuqizhou77 commented Apr 3, 2024

  • update manifest based on latest fix on manifest schema
    image

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base (0de595a) to head (1656aee).
Report is 20 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11266      +/-   ##
==========================================
+ Coverage   87.30%   87.37%   +0.06%     
==========================================
  Files         463      463              
  Lines       28091    28134      +43     
  Branches     5640     5637       -3     
==========================================
+ Hits        24526    24581      +55     
+ Misses       1787     1778       -9     
+ Partials     1778     1775       -3     
Files Coverage Δ
.../src/component/driver/teamsApp/createAppPackage.ts 90.39% <100.00%> (ø)
...c/component/driver/teamsApp/utils/ManifestUtils.ts 67.56% <100.00%> (+0.54%) ⬆️
packages/manifest/src/manifest.ts 100.00% <ø> (ø)
packages/spec-parser/src/constants.ts 100.00% <100.00%> (ø)
packages/spec-parser/src/manifestUpdater.ts 89.14% <ø> (ø)

... and 12 files with indirect coverage changes

refactor: more

test: ut
SLdragon
SLdragon previously approved these changes Apr 3, 2024
@yuqizhou77 yuqizhou77 merged commit a0ea763 into dev Apr 7, 2024
19 checks passed
@yuqizhou77 yuqizhou77 deleted the yuqzho/manifest-update branch April 7, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants