-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(spec-parser): update to support type b ai-plugin #10972
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #10972 +/- ##
==========================================
+ Coverage 87.00% 87.01% +0.01%
==========================================
Files 451 451
Lines 26779 26884 +105
Branches 5375 5401 +26
==========================================
+ Hits 23299 23394 +95
- Misses 1758 1760 +2
- Partials 1722 1730 +8
|
filter: string[], | ||
outputSpecPath: string, | ||
signal?: AbortSignal | ||
): Promise<GenerateResult> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also make ai-plugin.json as an input parameter? I think user may customize the file location when they want to use the codelens to add a new API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
parameters: parameters, | ||
states: { | ||
reasoning: { | ||
description: ConstantString.ReasoningDescription, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kind of curious why we use constant string here. sample value: https://spec-hub.azurewebsites.net/specifications/PluginManifest-draft.html#example-7 Should we leave it empty if we are not able to generate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we leave them empty
manifestPath: string, | ||
filter: string[], | ||
outputSpecPath: string, | ||
apiPluginFileName: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just want to confirm if you hope to pass the file name. might be better if it is path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update to use path instead of name
Example:
Code sample:
OpenAPI spec file:
Generated manifest file:
Generated ai-plugin file: