Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(spec parser): update spec parser for teams ai template #10952

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

KennethBWSong
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (889742a) to head (4b6e4f9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #10952   +/-   ##
=======================================
  Coverage   86.99%   87.00%           
=======================================
  Files         451      451           
  Lines       26769    26779   +10     
  Branches     5373     5375    +2     
=======================================
+ Hits        23289    23299   +10     
  Misses       1758     1758           
  Partials     1722     1722           
Files Coverage Δ
packages/spec-parser/src/interfaces.ts 100.00% <100.00%> (ø)
packages/spec-parser/src/manifestUpdater.ts 90.00% <100.00%> (ø)
packages/spec-parser/src/specParser.ts 97.14% <100.00%> (+0.19%) ⬆️

@KennethBWSong KennethBWSong marked this pull request as ready for review February 29, 2024 06:03
* @param filter An array of strings that represent the filters to apply when generating the artifacts. If filter is empty, it would process nothing.
* @param outputSpecPath File path of the new OpenAPI specification file to generate. If not specified or empty, no spec file will be generated.
* @param adaptiveCardFolder Folder path where the Adaptive Card files will be generated. If not specified or empty, Adaptive Card files will not be generated.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment for isME

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

@KennethBWSong KennethBWSong merged commit fccd829 into dev Feb 29, 2024
19 checks passed
@KennethBWSong KennethBWSong deleted the bowsong/spec_parser_update branch February 29, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants