perf: spec-parser to separate package #10842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: turenlong <rentu@microsoft.com>
* perf: add test files * perf: update test
* test: add browser test * perf: remove useless code
Co-authored-by: turenlong <rentu@microsoft.com>
* ci: add ci for spec-parser * test: update test * test: update test * test: update dependency
* ci: add cd for spec parser * fix: fix pacakge * test: fix ut
* perf: try to fix browser lib issue * perf: add missing constant export --------- Co-authored-by: turenlong <rentu@microsoft.com>
* perf: add format for spec parser * fix: add eslint file * build: update lock file
* perf: add license and update package.json * ci: update version
Co-authored-by: turenlong <rentu@microsoft.com>
Co-authored-by: turenlong <rentu@microsoft.com>
* perf: add test files * perf: update test
* test: add browser test * perf: remove useless code
Co-authored-by: turenlong <rentu@microsoft.com>
* ci: add ci for spec-parser * test: update test * test: update test * test: update dependency
* ci: add cd for spec parser * fix: fix pacakge * test: fix ut
* perf: try to fix browser lib issue * perf: add missing constant export --------- Co-authored-by: turenlong <rentu@microsoft.com>
* perf: add format for spec parser * fix: add eslint file * build: update lock file
* perf: add license and update package.json * ci: update version
Co-authored-by: turenlong <rentu@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!newPaths[path]) { | ||
| newPaths[path] = { ...unResolveSpec.paths[path] }; | ||
| for (const m of ConstantString.AllOperationMethods) { | ||
| delete (newPaths[path] as any)[m]; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| } | ||
| } | ||
|
|
||
| (newPaths[path] as any)[methodName] = (unResolveSpec.paths[path] as any)[methodName]; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| config.set(karmaConfig); | ||
| }; | ||
|
|
||
| function getTestFiles(argv) { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
wenytang-ms
reviewed
Feb 6, 2024
packages/spec-parser/package.json
Outdated
| "stream-http": "^3.2.0", | ||
| "swagger2openapi": "^7.0.8", | ||
| "url": "^0.11.3", | ||
| "webpack": "^5.90.0" |
There was a problem hiding this comment.
webpack is a deps? not devDeps?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #10842 +/- ##
==========================================
+ Coverage 86.88% 87.17% +0.29%
==========================================
Files 451 461 +10
Lines 26644 27335 +691
Branches 5332 5513 +181
==========================================
+ Hits 23149 23829 +680
+ Misses 1768 1759 -9
- Partials 1727 1747 +20
|
SLdragon
approved these changes
Feb 8, 2024
MuyangAmigo
approved these changes
Feb 8, 2024
wenytang-ms
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.