Skip to content

Commit

Permalink
perf(spec-parser): use summary for converation starter and truncate i…
Browse files Browse the repository at this point in the history
…t with 50 chars (#11474)

* perf(spec-parser): use summary for converation starter and truncate it with 50 chars

* perf: udpate

---------

Co-authored-by: rentu <rentu@microsoft.com>
  • Loading branch information
SLdragon and SLdragon authored Apr 25, 2024
1 parent d6c992f commit 79d8367
Show file tree
Hide file tree
Showing 3 changed files with 501 additions and 385 deletions.
1 change: 1 addition & 0 deletions packages/spec-parser/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export class ConstantString {
static readonly FullDescriptionMaxLens = 4000;
static readonly CommandDescriptionMaxLens = 128;
static readonly ParameterDescriptionMaxLens = 128;
static readonly ConversationStarterMaxLens = 50;
static readonly CommandTitleMaxLens = 32;
static readonly ParameterTitleMaxLens = 32;
static readonly SMERequiredParamsMaxNum = 5;
Expand Down
9 changes: 7 additions & 2 deletions packages/spec-parser/src/manifestUpdater.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export class ManifestUpdater {
if (operationItem) {
const operationId = operationItem.operationId!;
const description = operationItem.description ?? "";
const summary = operationItem.summary;
const paramObject = operationItem.parameters as OpenAPIV3.ParameterObject[];
const requestBody = operationItem.requestBody as OpenAPIV3.ParameterObject;

Expand Down Expand Up @@ -268,8 +269,12 @@ export class ManifestUpdater {

functions.push(funcObj);
functionNames.push(operationId);
if (description) {
conversationStarters.push(description);
const conversationStarterStr = (summary ?? description).slice(
0,
ConstantString.ConversationStarterMaxLens
);
if (conversationStarterStr) {
conversationStarters.push(conversationStarterStr);
}
}
}
Expand Down
Loading

0 comments on commit 79d8367

Please sign in to comment.