Removed importing from the entire public index.ts file (#2307)

* cleaned up some imports in the private folder --------- Co-authored-by: Trevor Harris <trharris@microsoft.com>
OfficeDev · May 7, 2024 · 565dfe5 · 565dfe5
1 parent ef47e4a
commit 565dfe5
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 11 deletions.
diff --git a/change/@microsoft-teams-js-963791e4-c448-4a4e-8a36-6c2c5b9b2035.json b/change/@microsoft-teams-js-963791e4-c448-4a4e-8a36-6c2c5b9b2035.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Cleaned up import structure in the `private` folder",
+  "packageName": "@microsoft/teams-js",
+  "email": "noahdarveau@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/teams-js/src/internal/marketplaceUtils.ts b/packages/teams-js/src/internal/marketplaceUtils.ts
@@ -2,7 +2,7 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 import { validate } from 'uuid';
 
-import { marketplace } from '../public';
+import { marketplace } from '../public/marketplace';
 
 /**
  * @hidden

diff --git a/packages/teams-js/src/private/appEntity.ts b/packages/teams-js/src/private/appEntity.ts
@@ -1,8 +1,8 @@
 import { sendMessageToParent } from '../internal/communication';
 import { ensureInitialized } from '../internal/internalAPIs';
 import { ApiName, ApiVersionNumber, getApiVersionTag } from '../internal/telemetry';
-import { FrameContexts, SdkError } from '../public';
-import { errorNotSupportedOnPlatform } from '../public/constants';
+import { errorNotSupportedOnPlatform, FrameContexts } from '../public/constants';
+import { SdkError } from '../public/interfaces';
 import { runtime } from '../public/runtime';
 
 /**

diff --git a/packages/teams-js/src/private/externalAppAuthentication.ts b/packages/teams-js/src/private/externalAppAuthentication.ts
@@ -2,8 +2,7 @@ import { sendMessageToParentAsync } from '../internal/communication';
 import { ensureInitialized } from '../internal/internalAPIs';
 import { ApiName, ApiVersionNumber, getApiVersionTag } from '../internal/telemetry';
 import { validateId, validateUrl } from '../internal/utils';
-import { FrameContexts } from '../public';
-import { errorNotSupportedOnPlatform } from '../public/constants';
+import { errorNotSupportedOnPlatform, FrameContexts } from '../public/constants';
 import { runtime } from '../public/runtime';
 
 /**

diff --git a/packages/teams-js/src/private/externalAppCardActions.ts b/packages/teams-js/src/private/externalAppCardActions.ts
@@ -2,8 +2,7 @@ import { sendMessageToParentAsync } from '../internal/communication';
 import { ensureInitialized } from '../internal/internalAPIs';
 import { ApiName, ApiVersionNumber, getApiVersionTag } from '../internal/telemetry';
 import { validateId } from '../internal/utils';
-import { FrameContexts } from '../public';
-import { errorNotSupportedOnPlatform } from '../public/constants';
+import { errorNotSupportedOnPlatform, FrameContexts } from '../public/constants';
 import { runtime } from '../public/runtime';
 import { ExternalAppErrorCode } from './constants';
 

diff --git a/packages/teams-js/src/private/externalAppCommands.ts b/packages/teams-js/src/private/externalAppCommands.ts
@@ -2,8 +2,7 @@ import { sendMessageToParentAsync } from '../internal/communication';
 import { ensureInitialized } from '../internal/internalAPIs';
 import { ApiName, ApiVersionNumber, getApiVersionTag } from '../internal/telemetry';
 import { validateId } from '../internal/utils';
-import { FrameContexts } from '../public';
-import { errorNotSupportedOnPlatform } from '../public/constants';
+import { errorNotSupportedOnPlatform, FrameContexts } from '../public/constants';
 import { runtime } from '../public/runtime';
 import { ExternalAppErrorCode } from './constants';
 import { externalAppAuthentication } from './externalAppAuthentication';

diff --git a/packages/teams-js/src/private/files.ts b/packages/teams-js/src/private/files.ts
@@ -2,7 +2,8 @@ import { sendMessageToParent } from '../internal/communication';
 import { registerHandler } from '../internal/handlers';
 import { ensureInitialized } from '../internal/internalAPIs';
 import { ApiName, ApiVersionNumber, getApiVersionTag } from '../internal/telemetry';
-import { ErrorCode, FileOpenPreference, FrameContexts, SdkError } from '../public';
+import { FrameContexts } from '../public/constants';
+import { ErrorCode, FileOpenPreference, SdkError } from '../public/interfaces';
 import { runtime } from '../public/runtime';
 
 /**

diff --git a/packages/teams-js/src/private/otherAppStateChange.ts b/packages/teams-js/src/private/otherAppStateChange.ts
@@ -3,7 +3,7 @@ import { registerHandler, removeHandler } from '../internal/handlers';
 import { ensureInitialized } from '../internal/internalAPIs';
 import { ApiName, ApiVersionNumber, getApiVersionTag } from '../internal/telemetry';
 import { isNullOrUndefined } from '../internal/typeCheckUtilities';
-import { ErrorCode } from '../public';
+import { ErrorCode } from '../public/interfaces';
 import { runtime } from '../public/runtime';
 
 /**