This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Added folderIds for SubscribeToStreamingNotifications#190
Open
LukaszGajowski wants to merge 1 commit intoOfficeDev:masterfrom
Open
Added folderIds for SubscribeToStreamingNotifications#190LukaszGajowski wants to merge 1 commit intoOfficeDev:masterfrom
LukaszGajowski wants to merge 1 commit intoOfficeDev:masterfrom
Conversation
|
|
davster
reviewed
Jul 5, 2018
|
|
||
| return this.BuildSubscribeToStreamingNotificationsRequest(folderIds, eventTypes).Execute()[0].Subscription; | ||
| StreamingSubscription StreamingSub = this.BuildSubscribeToStreamingNotificationsRequest(folderIds, eventTypes).Execute()[0].Subscription; | ||
| StreamingSub.folderIds = folderIds; |
Contributor
There was a problem hiding this comment.
Looking at this a bit more, it seems that it might be more effective to expose the request object off of the StreamingSubscription. This because I could see people being interested in the EventTypes as well. So you would add a Request prop on StreamingSubscription and remove your folderIds one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I develop app for monitoring Exchange by using SubscribeToStreamingNotifications and in StreamingSubscription class value of folderIds was lacked. And for some cases this information is needed for me.
In order not to modify a lot of code, I added support for this parameter in the easiest way as is possible.
Such functionality will certainly be useful for others as well.