Update Fabric Core URL #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJerabek
approved these changes
Oct 18, 2024
AlexJerabek
previously approved these changes
Oct 18, 2024
samantharamon
commented
Oct 21, 2024
AlexJerabek
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your pull request! Please provide the following information.
Change Description:
Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start')
If Yes, briefly describe what is impacted.
No.
Do these changes impact VS Code debugging options (launch.json)?
If Yes, briefly describe what is impacted.
No.
Do these changes impact template output? (e.g., add/remove file, update file location, update file contents)
If Yes, briefly describe what is impacted.
No.
Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
If Yes, briefly describe what is impacted.
Yes. Changes were made in Update Fabric Core URLs which were blocked by CORS policy office-js-docs-pr#4808.
If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct
Validation/testing performed: