Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused manifest property and fix spelling #277

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Rick-Kirkham
Copy link
Contributor

Change Description:

  1. The "displayName" property is only used in add-ins that have custom keyboard shortcuts. None of our templates have this feature.

  2. "task pane" should be 2 words

  3. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start')
    If Yes, briefly describe what is impacted.
    No

  4. Do these changes impact VS Code debugging options (launch.json)?
    If Yes, briefly describe what is impacted.
    No

  5. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents)
    If Yes, briefly describe what is impacted.
    No

  6. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
    If Yes, briefly describe what is impacted.
    No

If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct

Validation/testing performed:

Describe manual testing done. 

@Rick-Kirkham Rick-Kirkham requested a review from a team as a code owner October 10, 2024 20:15
@Rick-Kirkham Rick-Kirkham merged commit 2de8993 into master Oct 14, 2024
6 checks passed
@Rick-Kirkham Rick-Kirkham deleted the remove-unused-property branch October 14, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants