-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working Tab Removed Form App Manifest - Tab UI Template #1526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 23 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (3)
- samples/tab-ui-templates/ts/assets/sample.json: Language not supported
- samples/tab-ui-templates/ts/src/appManifest/manifest.json: Language not supported
- samples/tab-ui-templates/ts/src/appManifest_Hub/manifest.json: Language not supported
Comments suppressed due to low confidence (1)
samples/tab-ui-templates/ts/src/index.tsx:9
- Removing the .then() block after microsoftTeams.app.initialize() might cause the app to render before the initialization is complete. Ensure that the initialization is complete before rendering the App component.
microsoftTeams.app.initialize();
@@ -6,14 +6,13 @@ import reportWebVitals from "./report-web-vitals"; | |||
import { HashRouter } from "react-router-dom"; | |||
|
|||
// Initialize the Microsoft Teams SDK | |||
microsoftTeams.app.initialize().then(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We followed the all sample, including microsoftTeams.app.initialize().then(() => {. Could you confirm why it’s not working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes because, Microsoft Teams SDK requires the app to run inside the Teams environment.
Below method of initialization is working fine in Teams
microsoftTeams.app.initialize().then(() => {.})
Whereas M365, is an outside of Teams environment so it is blocking SDK Execution and giving error like app initialization failed,
And working fine after initializing using below method.
microsoftTeams.app.initialize()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks correct, Approving!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good Approved!!!
Executed Build Pipeline : https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/13536639182 |
Task board Tab was not working due to deprecated code and updated app manifest without that tab.
