Skip to content

chore: add missing UpgradeExecutor test #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore: add missing UpgradeExecutor test #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions test-e2e/tokenBridgeDeploymentTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,19 @@ describe('tokenBridge', () => {
)
}

const upgExecutor = new ethers.Contract(
const l1UpgradeExecutor = new ethers.Contract(
rollupAddresses.upgradeExecutor,
UpgradeExecutorABI,
l1Provider
)
await checkL1UpgradeExecutorInitialization(l1UpgradeExecutor, rollupAddresses);

const l2UpgradeExecutor = new ethers.Contract(
l2Deployment.upgradeExecutor,
UpgradeExecutorABI,
l2Provider
)
await checkL2UpgradeExecutorInitialization(upgExecutor, rollupAddresses)
await checkL2UpgradeExecutorInitialization(l2UpgradeExecutor, rollupAddresses)

await checkL1Ownership(l1Deployment, rollupAddresses)
await checkL2Ownership(l2Deployment, usingFeeToken)
Expand Down Expand Up @@ -298,6 +305,20 @@ async function checkL1WethGatewayInitialization(
)
}

async function checkL1UpgradeExecutorInitialization(
l1Executor: Contract,
rollupAddresses: RollupAddresses
) {
console.log('checkL1UpgradeExecutorInitialization')

//// check assigned/revoked roles are correctly set
const adminRole = await l1Executor.ADMIN_ROLE()
const executorRole = await l1Executor.EXECUTOR_ROLE()

expect(await l1Executor.hasRole(adminRole, l1Executor.address)).to.be.true
expect(await l1Executor.hasRole(executorRole, rollupAddresses.rollupOwner)).to.be.true
}

async function checkL2UpgradeExecutorInitialization(
l2Executor: Contract,
rollupAddresses: RollupAddresses
Expand Down