Skip to content

Make sure ether is not sent in ERC20 token bridge #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2023
Merged

Make sure ether is not sent in ERC20 token bridge #44

merged 2 commits into from
Oct 9, 2023

Conversation

@gvladika
Copy link
Contributor

@gvladika gvladika commented Oct 5, 2023

Make function non-payable forceRegisterTokenToL2 in L1OrbitCustomGateway

In outboundTransferCustomRefund of L1OrbitERC20Gateway require there's no value sent

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2023
@gvladika gvladika requested review from gzeoneth and yahgwai October 5, 2023 13:54
gzeoneth
gzeoneth approved these changes Oct 5, 2023
View reviewed changes
@gvladika gvladika merged commit 04aa5e6 into erc20-based-bridge Oct 9, 2023
@gzeoneth gzeoneth deleted the audit-updates branch July 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gzeoneth gzeoneth gzeoneth approved these changes

@yahgwai yahgwai Awaiting requested review from yahgwai

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gvladika @gzeoneth