-
Notifications
You must be signed in to change notification settings - Fork 156
feat: add master vault #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
951c33c
fc89964
7922536
6331e7a
5632d3d
2b8f151
5348604
3a24b45
db0feb1
1e0c267
4aad0dd
9ff2c39
e9d49e5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| interface IMasterVault { | ||
| function setSubVault(address subVault, uint256 minSubVaultExchRateWad) external; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| interface IMasterVaultFactory { | ||
| event VaultDeployed(address indexed token, address indexed vault); | ||
| event SubVaultSet(address indexed masterVault, address indexed subVault); | ||
|
|
||
| function initialize(address _owner) external; | ||
| function deployVault(address token) external returns (address vault); | ||
| function calculateVaultAddress(address token) external view returns (address); | ||
| function getVault(address token) external returns (address); | ||
| function setSubVault(address masterVault, address subVault, uint256 minSubVaultExchRateWad) external; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,287 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| import {ERC4626Upgradeable} from "@openzeppelin/contracts-upgradeable/token/ERC20/extensions/ERC4626Upgradeable.sol"; | ||
| import {ERC20Upgradeable} from "@openzeppelin/contracts-upgradeable/token/ERC20/ERC20Upgradeable.sol"; | ||
| import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | ||
| import {IERC20Upgradeable} from "@openzeppelin/contracts-upgradeable/token/ERC20/IERC20Upgradeable.sol"; | ||
| import {IERC4626} from "@openzeppelin/contracts/interfaces/IERC4626.sol"; | ||
| import {OwnableUpgradeable} from "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol"; | ||
| import {Initializable} from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol"; | ||
| import {IERC20Metadata} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol"; | ||
| import {MathUpgradeable} from "@openzeppelin/contracts-upgradeable/utils/math/MathUpgradeable.sol"; | ||
| import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol"; | ||
|
|
||
| contract MasterVault is Initializable, ERC4626Upgradeable, OwnableUpgradeable { | ||
| using SafeERC20 for IERC20; | ||
| using MathUpgradeable for uint256; | ||
|
|
||
| error TooFewSharesReceived(); | ||
| error TooManySharesBurned(); | ||
| error TooManyAssetsDeposited(); | ||
| error TooFewAssetsReceived(); | ||
| error SubVaultAlreadySet(); | ||
| error SubVaultCannotBeZeroAddress(); | ||
| error MustHaveSupplyBeforeSettingSubVault(); | ||
| error SubVaultAssetMismatch(); | ||
| error SubVaultExchangeRateTooLow(); | ||
| error NoExistingSubVault(); | ||
| error MustHaveSupplyBeforeSwitchingSubVault(); | ||
| error NewSubVaultExchangeRateTooLow(); | ||
| error BeneficiaryNotSet(); | ||
| error PerformanceFeeDisabled(); | ||
| error InvalidAsset(); | ||
| error InvalidOwner(); | ||
|
|
||
| // todo: avoid inflation, rounding, other common 4626 vulns | ||
| // we may need a minimum asset or master share amount when setting subvaults (bc of exchange rate calc) | ||
| IERC4626 public subVault; | ||
|
|
||
| // how many subVault shares one MV2 share can be redeemed for | ||
| // initially 1 to 1 | ||
| // constant per subvault | ||
| // changes when subvault is set | ||
| uint256 public subVaultExchRateWad; | ||
|
|
||
| // note: the performance fee can be avoided if the underlying strategy can be sandwiched (eg ETH to wstETH dex swap) | ||
| // maybe a simpler and more robust implementation would be for the owner to adjust the subVaultExchRateWad directly | ||
| // this would also avoid the need for totalPrincipal tracking | ||
| // however, this would require more trust in the owner | ||
| bool public enablePerformanceFee; | ||
| address public beneficiary; | ||
| uint256 totalPrincipal; // total assets deposited, used to calculate profit | ||
|
|
||
| event SubvaultChanged(address indexed oldSubvault, address indexed newSubvault); | ||
| event PerformanceFeeToggled(bool enabled); | ||
| event BeneficiaryUpdated(address indexed oldBeneficiary, address indexed newBeneficiary); | ||
|
|
||
| function initialize(IERC20 _asset, string memory _name, string memory _symbol, address _owner) external initializer { | ||
| if (address(_asset) == address(0)) revert InvalidAsset(); | ||
| if (_owner == address(0)) revert InvalidOwner(); | ||
|
|
||
| __ERC20_init(_name, _symbol); | ||
| __ERC4626_init(IERC20Upgradeable(address(_asset))); | ||
| _transferOwnership(_owner); | ||
|
|
||
| subVaultExchRateWad = 1e18; | ||
| } | ||
|
|
||
|
|
||
| function deposit(uint256 assets, address receiver, uint256 minSharesMinted) public returns (uint256) { | ||
| uint256 shares = deposit(assets, receiver); | ||
| if (shares < minSharesMinted) revert TooFewSharesReceived(); | ||
| return shares; | ||
| } | ||
|
|
||
| function withdraw(uint256 assets, address receiver, address _owner, uint256 maxSharesBurned) public returns (uint256) { | ||
| uint256 shares = withdraw(assets, receiver, _owner); | ||
| if (shares > maxSharesBurned) revert TooManySharesBurned(); | ||
| return shares; | ||
| } | ||
|
|
||
| function mint(uint256 shares, address receiver, uint256 maxAssetsDeposited) public returns (uint256) { | ||
| uint256 assets = super.mint(shares, receiver); | ||
| if (assets > maxAssetsDeposited) revert TooManyAssetsDeposited(); | ||
| return assets; | ||
| } | ||
|
|
||
| function redeem(uint256 shares, address receiver, address _owner, uint256 minAssetsReceived) public returns (uint256) { | ||
| uint256 assets = super.redeem(shares, receiver, _owner); | ||
| if (assets < minAssetsReceived) revert TooFewAssetsReceived(); | ||
| return assets; | ||
| } | ||
|
|
||
| /// @notice Set a subvault. Can only be called if there is not already a subvault set. | ||
| /// @param _subVault The subvault to set. Must be an ERC4626 vault with the same asset as this MasterVault. | ||
| /// @param minSubVaultExchRateWad Minimum acceptable ratio (times 1e18) of new subvault shares to outstanding MasterVault shares after deposit. | ||
| function setSubVault(IERC4626 _subVault, uint256 minSubVaultExchRateWad) external onlyOwner { | ||
| if (address(subVault) != address(0)) revert SubVaultAlreadySet(); | ||
| _setSubVault(_subVault, minSubVaultExchRateWad); | ||
| } | ||
|
|
||
| /// @notice Revokes the current subvault, moving all assets back to MasterVault | ||
| /// @param minAssetExchRateWad Minimum acceptable ratio (times 1e18) of assets received from subvault to outstanding MasterVault shares | ||
| function revokeSubVault(uint256 minAssetExchRateWad) external onlyOwner { | ||
| _revokeSubVault(minAssetExchRateWad); | ||
| } | ||
|
|
||
| function _setSubVault(IERC4626 _subVault, uint256 minSubVaultExchRateWad) internal { | ||
| if (address(_subVault) == address(0)) revert SubVaultCannotBeZeroAddress(); | ||
| if (totalSupply() == 0) revert MustHaveSupplyBeforeSettingSubVault(); | ||
| if (address(_subVault.asset()) != address(asset())) revert SubVaultAssetMismatch(); | ||
|
|
||
| IERC20(asset()).safeApprove(address(_subVault), type(uint256).max); | ||
| uint256 subShares = _subVault.deposit(totalAssets(), address(this)); | ||
|
|
||
| subVault = _subVault; | ||
|
|
||
| uint256 _subVaultExchRateWad = subShares.mulDiv(1e18, totalAssets(), MathUpgradeable.Rounding.Down); | ||
| if (_subVaultExchRateWad < minSubVaultExchRateWad) revert SubVaultExchangeRateTooLow(); | ||
| subVaultExchRateWad = _subVaultExchRateWad; | ||
|
|
||
| emit SubvaultChanged(address(0), address(_subVault)); | ||
| } | ||
|
Comment on lines
+108
to
+123
Check warningCode scanning / Slither Reentrancy vulnerabilities Medium
Reentrancy in MasterVault._setSubVault(IERC4626,uint256):
External calls: - IERC20(asset()).safeApprove(address(_subVault),type()(uint256).max) - subShares = _subVault.deposit(totalAssets(),address(this)) State variables written after the call(s): - subVault = _subVault MasterVault.subVault can be used in cross function reentrancies: - MasterVault._convertToAssets(uint256,MathUpgradeable.Rounding) - MasterVault._convertToShares(uint256,MathUpgradeable.Rounding) - MasterVault._deposit(address,address,uint256,uint256) - MasterVault._revokeSubVault(uint256) - MasterVault._setSubVault(IERC4626,uint256) - MasterVault._withdraw(address,address,address,uint256,uint256) - MasterVault.maxDeposit(address) - MasterVault.maxMint(address) - MasterVault.setSubVault(IERC4626,uint256) - MasterVault.subVault - MasterVault.totalAssets() - MasterVault.withdrawPerformanceFees() |
||
|
|
||
| function _revokeSubVault(uint256 minAssetExchRateWad) internal { | ||
| IERC4626 oldSubVault = subVault; | ||
| if (address(oldSubVault) == address(0)) revert NoExistingSubVault(); | ||
|
|
||
| uint256 _totalSupply = totalSupply(); | ||
| uint256 assetReceived = oldSubVault.withdraw(oldSubVault.maxWithdraw(address(this)), address(this), address(this)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is an edge case here - the subvault may not have enough liquidity to serve this big withdrawal all at once. we probably need to make switching vaults more robust to those liquidity constaints. the same could be said about depositing to the new vault, it could be such a large deposit that slippage starts to become a serious issue There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could do check whether |
||
| uint256 effectiveAssetExchRateWad = assetReceived.mulDiv(1e18, _totalSupply, MathUpgradeable.Rounding.Down); | ||
| if (effectiveAssetExchRateWad < minAssetExchRateWad) revert TooFewAssetsReceived(); | ||
|
|
||
| IERC20(asset()).safeApprove(address(oldSubVault), 0); | ||
| subVault = IERC4626(address(0)); | ||
| subVaultExchRateWad = 1e18; | ||
|
|
||
| emit SubvaultChanged(address(oldSubVault), address(0)); | ||
| } | ||
|
Comment on lines
+125
to
+139
Check warningCode scanning / Slither Reentrancy vulnerabilities Medium
Reentrancy in MasterVault._revokeSubVault(uint256):
External calls: - assetReceived = oldSubVault.withdraw(oldSubVault.maxWithdraw(address(this)),address(this),address(this)) - IERC20(asset()).safeApprove(address(oldSubVault),0) State variables written after the call(s): - subVault = IERC4626(address(0)) MasterVault.subVault can be used in cross function reentrancies: - MasterVault._convertToAssets(uint256,MathUpgradeable.Rounding) - MasterVault._convertToShares(uint256,MathUpgradeable.Rounding) - MasterVault._deposit(address,address,uint256,uint256) - MasterVault._revokeSubVault(uint256) - MasterVault._setSubVault(IERC4626,uint256) - MasterVault._withdraw(address,address,address,uint256,uint256) - MasterVault.maxDeposit(address) - MasterVault.maxMint(address) - MasterVault.setSubVault(IERC4626,uint256) - MasterVault.subVault - MasterVault.totalAssets() - MasterVault.withdrawPerformanceFees() |
||
|
|
||
| /// @notice Switches to a new subvault or revokes current subvault if newSubVault is zero address | ||
| /// @param newSubVault The new subvault to switch to, or zero address to revoke current subvault | ||
| /// @param minAssetExchRateWad Minimum acceptable ratio (times 1e18) of assets received from old subvault to outstanding MasterVault shares | ||
| /// @param minNewSubVaultExchRateWad Minimum acceptable ratio (times 1e18) of new subvault shares to outstanding MasterVault shares after deposit | ||
| function switchSubVault(IERC4626 newSubVault, uint256 minAssetExchRateWad, uint256 minNewSubVaultExchRateWad) external onlyOwner { | ||
| _revokeSubVault(minAssetExchRateWad); | ||
|
|
||
| if (address(newSubVault) != address(0)) { | ||
| _setSubVault(newSubVault, minNewSubVaultExchRateWad); | ||
| } | ||
| } | ||
|
|
||
| function masterSharesToSubShares(uint256 masterShares, MathUpgradeable.Rounding rounding) public view returns (uint256) { | ||
| return masterShares.mulDiv(subVaultExchRateWad, 1e18, rounding); | ||
| } | ||
|
|
||
| function subSharesToMasterShares(uint256 subShares, MathUpgradeable.Rounding rounding) public view returns (uint256) { | ||
| return subShares.mulDiv(1e18, subVaultExchRateWad, rounding); | ||
| } | ||
|
|
||
| /// @notice Toggle performance fee collection on/off | ||
| /// @param enabled True to enable performance fees, false to disable | ||
| function setPerformanceFee(bool enabled) external onlyOwner { | ||
| enablePerformanceFee = enabled; | ||
| emit PerformanceFeeToggled(enabled); | ||
| } | ||
|
|
||
| /// @notice Set the beneficiary address for performance fees | ||
| /// @param newBeneficiary Address to receive performance fees, zero address defaults to owner | ||
| function setBeneficiary(address newBeneficiary) external onlyOwner { | ||
| address oldBeneficiary = beneficiary; | ||
| beneficiary = newBeneficiary; | ||
| emit BeneficiaryUpdated(oldBeneficiary, newBeneficiary); | ||
| } | ||
|
|
||
| /// @notice Withdraw all accumulated performance fees to beneficiary | ||
| /// @dev Only callable by owner when performance fees are enabled | ||
| function withdrawPerformanceFees() external onlyOwner { | ||
| if (!enablePerformanceFee) revert PerformanceFeeDisabled(); | ||
| if (beneficiary == address(0)) revert BeneficiaryNotSet(); | ||
|
|
||
| uint256 totalProfits = totalProfit(); | ||
| if (totalProfits > 0) { | ||
| IERC4626 _subVault = subVault; | ||
| if (address(_subVault) != address(0)) { | ||
| _subVault.withdraw(totalProfits, address(this), address(this)); | ||
| } | ||
| IERC20(asset()).safeTransfer(beneficiary, totalProfits); | ||
| } | ||
| } | ||
|
|
||
| /** @dev See {IERC4626-totalAssets}. */ | ||
| function totalAssets() public view virtual override returns (uint256) { | ||
| IERC4626 _subVault = subVault; | ||
| if (address(_subVault) == address(0)) { | ||
| return super.totalAssets(); | ||
| } | ||
| return _subVault.convertToAssets(_subVault.balanceOf(address(this))); | ||
| } | ||
|
|
||
| /** @dev See {IERC4626-maxDeposit}. */ | ||
| function maxDeposit(address) public view virtual override returns (uint256) { | ||
| if (address(subVault) == address(0)) { | ||
| return type(uint256).max; | ||
| } | ||
| return subVault.maxDeposit(address(this)); | ||
| } | ||
|
|
||
| /** @dev See {IERC4626-maxMint}. */ | ||
| function maxMint(address) public view virtual override returns (uint256) { | ||
| uint256 subShares = subVault.maxMint(address(this)); | ||
| if (subShares == type(uint256).max) { | ||
| return type(uint256).max; | ||
| } | ||
| return subSharesToMasterShares(subShares, MathUpgradeable.Rounding.Down); | ||
| } | ||
|
|
||
| /** | ||
| * @dev Internal conversion function (from assets to shares) with support for rounding direction. | ||
| * | ||
| * Will revert if assets > 0, totalSupply > 0 and totalAssets = 0. That corresponds to a case where any asset | ||
| * would represent an infinite amount of shares. | ||
| */ | ||
| function _convertToShares(uint256 assets, MathUpgradeable.Rounding rounding) internal view virtual override returns (uint256 shares) { | ||
| IERC4626 _subVault = subVault; | ||
| if (address(_subVault) == address(0)) { | ||
| return super._convertToShares(assets, rounding); | ||
| } | ||
| uint256 subShares = rounding == MathUpgradeable.Rounding.Up ? _subVault.previewWithdraw(assets) : _subVault.previewDeposit(assets); | ||
| return subSharesToMasterShares(subShares, rounding); | ||
| } | ||
|
|
||
| /** | ||
| * @dev Internal conversion function (from shares to assets) with support for rounding direction. | ||
| */ | ||
| function _convertToAssets(uint256 shares, MathUpgradeable.Rounding rounding) internal view virtual override returns (uint256 assets) { | ||
| IERC4626 _subVault = subVault; | ||
| if (address(_subVault) == address(0)) { | ||
| return super._convertToAssets(shares, rounding); | ||
| } | ||
| uint256 subShares = masterSharesToSubShares(shares, rounding); | ||
| return rounding == MathUpgradeable.Rounding.Up ? _subVault.previewMint(subShares) : _subVault.previewRedeem(subShares); | ||
| } | ||
|
|
||
| function totalProfit() public view returns (uint256) { | ||
| uint256 _totalAssets = totalAssets(); | ||
| return _totalAssets > totalPrincipal ? _totalAssets - totalPrincipal : 0; | ||
| } | ||
|
|
||
| /** | ||
| * @dev Deposit/mint common workflow. | ||
| */ | ||
| function _deposit( | ||
| address caller, | ||
| address receiver, | ||
| uint256 assets, | ||
| uint256 shares | ||
| ) internal virtual override { | ||
| super._deposit(caller, receiver, assets, shares); | ||
|
|
||
| totalPrincipal += assets; | ||
| IERC4626 _subVault = subVault; | ||
| if (address(_subVault) != address(0)) { | ||
| _subVault.deposit(assets, address(this)); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @dev Withdraw/redeem common workflow. | ||
| */ | ||
| function _withdraw( | ||
| address caller, | ||
| address receiver, | ||
| address _owner, | ||
| uint256 assets, | ||
| uint256 shares | ||
| ) internal virtual override { | ||
| totalPrincipal -= assets; | ||
|
|
||
| IERC4626 _subVault = subVault; | ||
| if (address(_subVault) != address(0)) { | ||
| _subVault.withdraw(assets, address(this), address(this)); | ||
| } | ||
|
|
||
| super._withdraw(caller, receiver, _owner, assets, shares); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| pragma solidity ^0.8.0; | ||
|
|
||
| import "@openzeppelin/contracts/utils/Create2.sol"; | ||
| import "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol"; | ||
| import "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol"; | ||
| import "@openzeppelin/contracts/proxy/beacon/UpgradeableBeacon.sol"; | ||
| import "../ClonableBeaconProxy.sol"; | ||
| import "./IMasterVault.sol"; | ||
| import "./IMasterVaultFactory.sol"; | ||
| import "./MasterVault.sol"; | ||
|
|
||
| contract MasterVaultFactory is IMasterVaultFactory, OwnableUpgradeable { | ||
| error ZeroAddress(); | ||
| error BeaconNotDeployed(); | ||
|
|
||
| BeaconProxyFactory public beaconProxyFactory; | ||
|
|
||
| function initialize(address _owner) public initializer { | ||
| _transferOwnership(_owner); | ||
|
|
||
| MasterVault masterVaultImplementation = new MasterVault(); | ||
| UpgradeableBeacon beacon = new UpgradeableBeacon(address(masterVaultImplementation)); | ||
| beaconProxyFactory = new BeaconProxyFactory(); | ||
| beaconProxyFactory.initialize(address(beacon)); | ||
| beacon.transferOwnership(_owner); | ||
| } | ||
|
|
||
| function deployVault(address token) public returns (address vault) { | ||
| if (token == address(0)) { | ||
| revert ZeroAddress(); | ||
| } | ||
| if ( | ||
| address(beaconProxyFactory) == address(0) && beaconProxyFactory.beacon() == address(0) | ||
| ) { | ||
| revert BeaconNotDeployed(); | ||
| } | ||
|
|
||
| bytes32 userSalt = _getUserSalt(token); | ||
| vault = beaconProxyFactory.createProxy(userSalt); | ||
|
|
||
| IERC20Metadata tokenMetadata = IERC20Metadata(token); | ||
| string memory name = string(abi.encodePacked("Master ", tokenMetadata.name())); | ||
| string memory symbol = string(abi.encodePacked("m", tokenMetadata.symbol())); | ||
|
|
||
| MasterVault(vault).initialize(IERC20(token), name, symbol, address(this)); | ||
|
|
||
| emit VaultDeployed(token, vault); | ||
| } | ||
|
|
||
| function _getUserSalt(address token) internal pure returns (bytes32) { | ||
| return keccak256(abi.encode(token)); | ||
| } | ||
|
|
||
| function calculateVaultAddress(address token) public view returns (address) { | ||
| bytes32 userSalt = _getUserSalt(token); | ||
| return beaconProxyFactory.calculateExpectedAddress(address(this), userSalt); | ||
| } | ||
|
|
||
| function getVault(address token) external returns (address) { | ||
| address vault = calculateVaultAddress(token); | ||
| if (vault.code.length == 0) { | ||
| return deployVault(token); | ||
| } | ||
| return vault; | ||
| } | ||
|
|
||
| // todo: consider a method to enable bridge owner to transfer specific master vault ownership to new address | ||
| function setSubVault( | ||
| address masterVault, | ||
| address subVault, | ||
| uint256 minSubVaultExchRateWad | ||
| ) external onlyOwner { | ||
| IMasterVault(masterVault).setSubVault(subVault, minSubVaultExchRateWad); | ||
| emit SubVaultSet(masterVault, subVault); | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Dangerous strict equalities Medium