Skip to content

add missing nativeToken property to local network #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged

add missing nativeToken property to local network #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9284fe
add missing nativeToken property to local network
godzillaba Aug 5, 2025
08203c2
do not scale fee amount in test since sdk now handles
godzillaba Aug 5, 2025
94279df
chore: bump version to 1.2.5
gzeoneth Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@arbitrum/token-bridge-contracts",
"version": "1.2.4",
"version": "1.2.5",
"license": "Apache-2.0",
"scripts": {
"prepublishOnly": "hardhat clean && hardhat compile",
Expand Down
8 changes: 8 additions & 0 deletions scripts/local-deployment/localDeploymentLib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
} from '../atomicTokenBridgeDeployer'
import {
ERC20__factory,
IERC20Bridge__factory,
IOwnable__factory,
TestWETH9__factory,
} from '../../build/types'
Expand Down Expand Up @@ -240,7 +241,14 @@ export const getLocalNetwork = async (
const bridge = Bridge__factory.connect(data.bridge, l1Provider)
const outboxAddr = await bridge.allowedOutboxList(0)

let nativeToken: string | undefined = undefined
try {
nativeToken = await IERC20Bridge__factory.connect(data.bridge, l1Provider).nativeToken()
}
catch {}

const l2Network: ArbitrumNetwork = {
nativeToken,
parentChainId: l1NetworkInfo.chainId,
chainId: l2NetworkInfo.chainId,
confirmPeriodBlocks: 20,
Expand Down
16 changes: 2 additions & 14 deletions test-e2e/orbitTokenBridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,20 +479,8 @@ describe('orbitTokenBridge', () => {
)

// approve fee amount
const valueForGateway = nativeToken
? await _getScaledAmount(
nativeToken.address,
gwRetryableParams.deposit,
nativeToken.provider!
)
: gwRetryableParams.deposit
const valueForRouter = nativeToken
? await _getScaledAmount(
nativeToken.address,
routerRetryableParams.deposit,
nativeToken.provider!
)
: routerRetryableParams.deposit
const valueForGateway = gwRetryableParams.deposit
const valueForRouter = routerRetryableParams.deposit
const registrationFee = valueForGateway.add(valueForRouter).mul(2)
if (nativeToken) {
await (
Expand Down