fixing builder preference push frequency - #17386
Open
james-prysm wants to merge 13 commits into
Open
Conversation
…ency of builder preferences being pushed
james-prysm
marked this pull request as ready for review
August 20, 2026 15:28
syjn99
reviewed
Aug 24, 2026
| v.pushPreferences(ctx, km, slot, connGen, forceFullPush) | ||
| return nil | ||
| } | ||
| return v.pushPreGloasSettings(ctx, km, filteredKeys, slot, connGen, forceFullPush) |
Member
There was a problem hiding this comment.
Seems like filteredKeys is only needed for pre-Gloas flow. Can we put the fetching logic for filteredKeys inside pushPreGloasSettings?
Contributor
Author
There was a problem hiding this comment.
it also updates status, it's needed for both
Member
There was a problem hiding this comment.
it also updates status, it's needed for both
Could you clarify this? If currentEpoch >= params.BeaconConfig().GloasForkEpoch, filteredKeys is not used anymore, as it is only consumed for pre-Gloas path.
Contributor
Author
There was a problem hiding this comment.
my bad i read through it too quickly i thought it was around the function,
refactored here 445ef83
syjn99
previously approved these changes
Aug 26, 2026
syjn99
approved these changes
Aug 26, 2026
james-prysm
enabled auto-merge
August 26, 2026 14:58
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2026
james-prysm
enabled auto-merge
August 26, 2026 18:39
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 27, 2026
james-prysm
enabled auto-merge
August 27, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
due to an old design builder preferences were submitting once per slot, but this changes with ethereum/beacon-APIs#630
state.proposer_lookahead), sobuilders hold the preferences before the bid request arrives.
My interpretation of this is that they can be sent alongside proposer preferences and act similarly timing wise as it also is sent in the prior epoch before the epoch where the validator is proposing. In this design because it still follows that I am submitting half way into the epoch just like proposer preferences
I've refactored how the code is written to improve readability for pre and post gloas preferences
Some changes also introduced to make builder preferences match proposer preferences for dedupes and reconnections.
Note: this pr does not solve an existing issue with post gloas preferences around the interactions of dedupes and reconnections, that will be addressed in a future pr
Which issue(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements