feat(p2p): upgrade go-libp2p to v0.45.0 and add stream error codes #16119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades go-libp2p from v0.39.1 to v0.45.0 and implements stream error codes for improved error signaling to peers. The upgrade brings enhanced observability through stream error codes (available since v0.42.0), QUIC security improvements, and connection rate limiting capabilities. The PR also includes necessary fixes for test assertions and multiaddr comparisons that became necessary due to the dependency updates.
Key Changes
- Upgraded go-libp2p from v0.39.1 to v0.45.0, along with related dependency updates (go-libp2p-mplex, various transitive dependencies)
- Replaced
stream.Reset()calls withstream.ResetWithError(code)throughout the codebase to signal specific error conditions to peers - Fixed
NoErrortest assertion to properly handle struct error types usingdeepNil()helper - Updated multiaddr comparison in tests to use
.Equal()method for compatibility with go-multiaddr v0.16.0
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod, go.sum, deps.bzl | Updated go-libp2p to v0.45.0 and related dependencies with version bumps across the dependency tree |
| beacon-chain/sync/rpc.go | Changed deferred stream reset to use StreamShutdown error code |
| beacon-chain/sync/error.go | Updated stream reset on CloseWrite failure to use StreamNoError code |
| beacon-chain/p2p/sender.go | Added error codes: StreamProtocolViolation on encoding errors, StreamNoError on CloseWrite failures |
| beacon-chain/p2p/testing/p2p.go | Applied same error code patterns in test helper for Send operations |
| cmd/prysmctl/p2p/handler.go | Changed deferred stream reset to use StreamShutdown error code |
| cmd/prysmctl/p2p/client.go | Added error codes: StreamProtocolViolation on encoding errors, StreamNoError on CloseWrite failures |
| testing/assertions/assertions.go | Refactored NoError assertion to use existing deepNil() helper, fixing panic on nil-valued struct error types |
| beacon-chain/p2p/peers/status_test.go | Updated multiaddr equality checks to use .Equal() method instead of direct comparison |
| changelog/willianpaixao_stream-error-codes.md | Added changelog documenting the upgrade and fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@nalepae @aarshkshah1992 maybe I could get a review over here too? |
Upgrade go-libp2p from v0.39.1 to v0.45.0 to leverage stream error codes for better error signaling to peers. Changes: - Replace stream.Reset() with stream.ResetWithError(code) - Use StreamProtocolViolation for encoding errors - Use StreamNoError for CloseWrite failures (cleanup) - Use StreamShutdown for handler cleanup on exit Dependency upgrades: - go-libp2p: v0.39.1 -> v0.45.0 - go-libp2p-mplex: v0.9.0 -> v0.11.0 Signed-off-by: Willian Paixao <willian@ufpa.br>
willianpaixao
force-pushed
the
error-codes
branch
from
086f041 to
ddaab9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Upgrades go-libp2p from v0.39.1 to v0.45.0 and implements stream error codes for better error signaling to peers.
The upgrade provides stream error codes (v0.42.0+) which allow signaling why a stream was reset, improving observability and debugging. Additional benefits include QUIC security improvements and connection rate limiting capabilities.
Dependency Upgrades
go-libp2p: v0.39.1 -> v0.45.0go-libp2p-mplex: v0.9.0 -> v0.11.0Which issues(s) does this PR fix?
I have not created an issue.
Acknowledgements