Fulu: Safegard against accidential out of bounds array access in dataColumnSidecars method #15586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
force-pushed
the
fulu-datacolumn-sidecars-oob
branch
from
30ce982 to
02187ba
Compare
Inspector-Butters
approved these changes
Aug 13, 2025
james-prysm
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This adds a smiple validation that could prevent a panic if the code were misused or run in an unusual/impossible scenario.
Which issues(s) does this PR fix?
No known issues. Data columns are in fulu which has not occurred in any testnet or mainnet yet.
Other notes for review
Acknowledgements