refactor: use central flag name for validator HTTP server port #15236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prestonvanloon
approved these changes
Jun 2, 2025
|
Thanks! That was an easy TODO 😄 |
|
Hi @prestonvanloon 👋 Thanks again for the review and approval! I’ve just updated the branch with Let me know if there's anything else I can help with to move this forward. |
jtraglia
pushed a commit
to jtraglia/prysm
that referenced
this pull request
Aug 11, 2025
…ainLabs#15236) * Update validator.go * Create tomasandroil_replace_grpc_gateway_flag_name.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
This PR replaces the hardcoded
"grpc-gateway-port"string with a reference toflags.HTTPServerPort.Name, ensuring consistency across the codebase when defining the validator client's HTTP server port.This change is minor and safe, as the referenced constant holds the same value (
"grpc-gateway-port") and prevents future desynchronization if the flag name ever changes.Which issues(s) does this PR fix?
None.
Other notes for review
No behavior or logic is changed; this is a minor internal refactor. No other files are affected (e.g., lighthouse or non-prysm clients).
Acknowledgements