Conversation
nalepae
force-pushed
the
remove-fulu-block-state
branch
from
b037b20 to
7c00886
Compare
nalepae
force-pushed
the
remove-fulu-block-state
branch
2 times, most recently
from
0b3075a to
5c8bcee
Compare
nalepae
force-pushed
the
remove-fulu-block-state
branch
11 times, most recently
from
1afc93c to
f7774b4
Compare
nalepae
force-pushed
the
remove-fulu-block-state
branch
from
f7774b4 to
a2d3db0
Compare
rkapka
reviewed
Feb 13, 2025
| // Error is returned if the input is not type protobuf beacon state. | ||
| func ProtobufBeaconStateFulu(s interface{}) (*ethpb.BeaconStateFulu, error) { | ||
| pbState, ok := s.(*ethpb.BeaconStateFulu) | ||
| func ProtobufBeaconStateFulu(s interface{}) (*ethpb.BeaconStateElectra, error) { |
Contributor
There was a problem hiding this comment.
Is this function needed? Can't we alias ProtobufBeaconStateElectra?
|
|
||
| message SignedBlindedBeaconBlockFulu { | ||
| // The unsigned blinded beacon block itself. | ||
| BlindedBeaconBlockFulu message = 1; |
Contributor
There was a problem hiding this comment.
I can't find the definition for some reason, but is BlindedBeaconBlockFulu needed? You did remove the full block
Contributor
Author
There was a problem hiding this comment.
The definition of BlindedBeaconBlockFulu is here.
Contributor
Author
There was a problem hiding this comment.
- In
produceBlockV3, to produce a non blinded block, we need to compare type against*eth.GenericBeaconBlock_Fulu. *eth.GenericBeaconBlock_Fuluis created here and is of typeBeaconBlockContentsFulu(and not of typeBeaconBlockFulu).
- In
produceBlockV3, to produce a blinded block, we need to compare type against*eth.GenericBeaconBlock_BlindedFulu. *eth.GenericBeaconBlock_BlindedFuluis created here and is of typeBlindedBeaconBlockFulu.
==> I need both BlindedBeaconBlockFulu and BeaconBlockContentsFulu, but I don't need BlindedBeaconBlockFulu.
Contributor
Author
There was a problem hiding this comment.
We do all this to set version.String(version.Fulu)) on Fulu blocks.
(Even if the shape of the struct is exactly the same than Electra block.)
| ExecutionRequests *ExecutionRequests `json:"execution_requests"` | ||
| } | ||
|
|
||
| type BlindedBeaconBlockFulu struct { |
Contributor
There was a problem hiding this comment.
Is this needed? Se comment in proto/prysm/v1alpha1/beacon_block.proto
rkapka
approved these changes
Feb 14, 2025
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
* Remove Fulu block and state. * Add missing tests. * Alias `ProtobufBeaconStateFulu` to `ProtobufBeaconStateElectra`
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
* Remove Fulu block and state. * Add missing tests. * Alias `ProtobufBeaconStateFulu` to `ProtobufBeaconStateElectra`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Remove as much as Fulu proto definitions. (Including Fulu block and state.)
How I realized this PR:
blk.Versionreturnedelectrafor a Fulu block.3.(being able to differentiate versions), I had to re-add some Fulu structs, even if they are the same than the Electra ones. Only the minimal amount of structs have been added.Acknowledgements