Fix 'data_column_sidecar_computation' metric align with PeerDAS metrics specs

[KatyaRyazantseva]

What type of PR is this?

Feature

What does this PR do? Why is it needed?
This PR adjusts PeerDAS metric beacon_data_column_sidecar_computation_seconds align with the PeerDAS metrics specs:

• rename the metric
• change milliseconds to seconds

Which issues(s) does this PR fix?

Fixes (partially) #14129

Other notes for review

Acknowledgements

• I have read CONTRIBUTING.md.
• I have made an appropriate entry to CHANGELOG.md.
• I have added a description to this PR with sufficient context for reviewers to understand this PR.

[CLAassistant]

All committers have signed the CLA.

[nisdas]

I disagree with changing the unit to seconds. Most metrics recorded are going to be simply 0,1 or 2 which isn't useful at all. Milliseconds is a much more useful unit of time to gauge (1400ms vs 1s) as you have much greater granularity

[nalepae]

@KatyaRyazantseva sorry for the inconvenience, would it be possible to reset your PR on top of the current peerDAS branch?

(I rebased the peerDAS branch on top on develop after you created your PR, so that's why there is plenty of commits.)

[nalepae]

I disagree with changing the unit to seconds. Most metrics recorded are going to be simply 0,1 or 2 which isn't useful at all. Milliseconds is a much more useful unit of time to gauge (1400ms vs 1s) as you have much greater granularity

The metric is a float, not an int right?

If so; instead of 1400ms, we should have 1.4s, not 1s.

[nisdas]

The metric is a float, not an int right?

If so; instead of 1400ms, we should have 1.4s, not 1s.

Metric is a float but the time is not, It is a discrete quantity, so if you ask it for seconds you will only get 1 instead of 1.4