Skip to content

Some places return an epoch where a sync committee period is expected instead #14206

@rupam-04

Description

@rupam-04

💎 Issue

Background

@rkapka pointed out in this PR #14186
#14186 (comment)

Description

I went ahead to see in which other places the helper function compute_sync_committee_period_at_slot from CL specs
has been used as slots.ToEpoch() in the already existing implementations and asked @rkapka if they were correct or not. He said they were incorrect too and we need to wrap them using slots.SyncCommitteePeriod(). One such example would be https://github.com/prysmaticlabs/prysm/blob/7c81c7da903884fd34ead687cfcba2ab6848639b/beacon-chain/rpc/eth/light-client/helpers.go#L164

Right now the fix is blocked by #14186 as the latter is working with the same file. Once it gets merged I'll start working on this fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions