Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace Transfers #664

Merged
merged 12 commits into from
Jun 17, 2022
Merged

Trace Transfers #664

merged 12 commits into from
Jun 17, 2022

Conversation

rachel-bousfield
Copy link
Contributor

@rachel-bousfield rachel-bousfield commented Jun 6, 2022 •
edited
Loading

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #664 (5aa33f2) into master (3703ad8) will increase coverage by 0.02%.
The diff coverage is 76.92%.

❗ Current head 5aa33f2 differs from pull request most recent head ecc1c0a. Consider uploading reports for the commit ecc1c0a to get more accurate results

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   47.53%   47.56%   +0.02%     
==========================================
  Files         214      214              
  Lines       22396    22408      +12     
  Branches      497      497              
==========================================
+ Hits        10647    10659      +12     
- Misses      10358    10363       +5     
+ Partials     1391     1386       -5

@rachel-bousfield rachel-bousfield marked this pull request as ready for review June 14, 2022 13:02
PlasmaPower
PlasmaPower reviewed Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple recommended purpose string changes but other than that LGTM

arbos/tx_processor.go Outdated Show resolved Hide resolved
precompiles/ArbSys.go Outdated Show resolved Hide resolved
PlasmaPower
PlasmaPower approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 848372e into master Jun 17, 2022
@PlasmaPower PlasmaPower deleted the trace-transfers branch June 17, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachel-bousfield @PlasmaPower