-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support non-clean shutdown #1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
- Coverage 48.03% 47.75% -0.28%
==========================================
Files 218 218
Lines 25180 25207 +27
Branches 523 523
==========================================
- Hits 12094 12037 -57
- Misses 11477 11538 +61
- Partials 1609 1632 +23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Dismissing approval as Harry has some suggestions for the geth side
arbnode/node.go
Outdated
Archive: false, | ||
BlockCount: 128, | ||
BlockAge: 30 * time.Minute, | ||
TrieTimeLimit: 5 * time.Minute, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update this to an hour and then LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed up a commit changing this to an hour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This only works if node works for more than 1 hours.. not an amazing solution as it can be in sync for less than a hour thus if restarted in less than 1 hour state gets bricked |
@hdiass this is configurable with |
uses geth shutdown markers (requires stopping blockchain before backend)
logs time for block creation fo blockchain will write trie cache
Pulls in OffchainLabs/go-ethereum#155