Skip to content

feat: deploy custom da validator #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gzeoneth wants to merge 2 commits into
base: release-3.2.0
Choose a base branch
from
Open

feat: deploy custom da validator #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb7eab8
feat: deploy custom da validator
gzeoneth Dec 9, 2025
da75179
fix: factory should have no custom da
gzeoneth Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions scripts/deployOsp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,28 @@ import { deployOneStepProofEntry } from './deploymentUtils'
async function main() {
const [deployer] = await ethers.getSigners()

// Get custom DA validator address from environment variable
const customDAValidator =
process.env.CUSTOM_DA_VALIDATOR || ethers.constants.AddressZero

console.log('Deploying OneStepProofEntry with the following configuration:')
console.log('Deployer:', deployer.address)
console.log('Custom DA Validator:', customDAValidator)
console.log('Network:', (await ethers.provider.getNetwork()).name)

// Validate the custom DA validator address if provided
if (customDAValidator !== ethers.constants.AddressZero) {
// Check if the address has code deployed
const code = await ethers.provider.getCode(customDAValidator)
if (code === '0x') {
console.warn('WARNING: Custom DA validator address has no code deployed')
}
}

// Deploy OneStepProofEntry and its dependencies
const deployment = await deployOneStepProofEntry(
deployer,
customDAValidator,
process.env.DISABLE_VERIFICATION !== 'true'
)

Expand Down
5 changes: 3 additions & 2 deletions scripts/deploymentUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export async function create2(

export async function deployOneStepProofEntry(
signer: any,
customDAValidator: string,
verify: boolean = true
): Promise<{
prover0: Contract
Expand Down Expand Up @@ -198,7 +199,7 @@ export async function deployOneStepProofEntry(
const proverHostIo = await deployContract(
'OneStepProverHostIo',
signer,
[ethers.constants.AddressZero],
[customDAValidator],
verify,
true
)
Expand Down Expand Up @@ -348,7 +349,7 @@ export async function deployAllContracts(
true
)
const { prover0, proverMem, proverMath, proverHostIo, osp } =
await deployOneStepProofEntry(signer, verify)
await deployOneStepProofEntry(signer, ethers.constants.AddressZero, verify)
Copy link
Contributor

@godzillaba godzillaba Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to pass a real value here?

Copy link
Member Author

@gzeoneth gzeoneth Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factory should always have no custom da

Copy link
Contributor

@godzillaba godzillaba Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah makes sense

const challengeManager = await deployContract(
'EdgeChallengeManager',
signer,
Expand Down
Loading