Custom da legacy #353
Draft
Custom da legacy #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement CustomDA preimage type support in OneStepProverHostIo: - Add VALIDATE_PREIMAGE opcode (0x8019) to Instructions.sol - Implement executeValidatePreimage for CustomDA preimages - Extend executeReadPreImage to handle CustomDA preimage type - Create ICustomDAValidator interface for DA proof validation
tsahee
requested changes
Jun 3, 2025
| // Custom validator contract proof | ||
| // Format: [validatorAddress (20 bytes)][proof data] | ||
| require(proof.length >= proofOffset + 20, "INVALID_CUSTOMDA_PROOF"); | ||
| address validatorAddress = address(bytes20(proof[proofOffset:proofOffset+20])); |
There was a problem hiding this comment.
you cannot read validatorAddress from the proof.
It must be a variable of a contract that only chain owner can set (during contract initialization and/or upgraade)
|
|
||
| bool valid = false; | ||
|
|
||
| if (proofType == 0) { |
There was a problem hiding this comment.
I don't think we need to support a simple proof type. external DA contract should be able to deal with anything that could come here
| @@ -236,6 +307,52 @@ contract OneStepProverHostIo is IOneStepProver { | |||
|
|
|||
| extracted = kzgProof[64:96]; | |||
| } | |||
| } else if (inst.argumentData == 3) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.