Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support non-clean shutdown #155

Merged
merged 17 commits into from
Sep 1, 2022
Merged

support non-clean shutdown #155

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1724b96
prune based on both time and height
rachel-bousfield Aug 22, 2022
04e3b83
fix off by one
rachel-bousfield Aug 22, 2022
678fc20
add comments and tweak logic
rachel-bousfield Aug 22, 2022
4f57a35
correct comment
rachel-bousfield Aug 22, 2022
2ce4b28
improve comment
rachel-bousfield Aug 22, 2022
e6d8faa
fix editor issue
rachel-bousfield Aug 22, 2022
21d73e3
Merge branch 'master' into time-based-pruning
rachel-bousfield Aug 24, 2022
c6ebd8c
arbitrum backend: use shutdown marker
tsahee Aug 28, 2022
ef4387e
blockchain WriteBlockAndSetHeadWithTime
tsahee Aug 29, 2022
9cf4cb7
Merge remote-tracking branch 'origin/time-based-pruning' into shutdow…
tsahee Aug 30, 2022
57a6751
fix deadlock in FindRetentionBound
tsahee Aug 30, 2022
f490228
move WriteBlockAndSetHeadWithTime to blockchain_arbitrum
tsahee Aug 30, 2022
47ee58b
fast-exist FindRetentionBound
tsahee Aug 30, 2022
79c1b15
use triegc for trie retention
tsahee Aug 30, 2022
6e88a28
fix offset when stopping blockchain
tsahee Aug 30, 2022
494b0a5
commit oldest in-memory trie on shutdown
tsahee Aug 30, 2022
7503143
commit both oldest and tries-in-memory on shutdown
tsahee Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix off by one
  • Loading branch information
@rachel-bousfield
rachel-bousfield committed Aug 22, 2022
commit 04e3b830f9c4aaa9edc3c6099a5eafffb43f5364
6 changes: 3 additions & 3 deletions core/blockchain_arbitrum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,16 @@ func (bc *BlockChain) FindRetentionBound() uint64 {
}

// binary search on the interval [a, b] for the first insufficiently old block
a := timeBound
a := timeBound + 1
b := heightBound
for a != b {
mid := a/2 + b/2
age := current.Time() - bc.GetBlockByNumber(mid).Time()
if age < minimumAge {
b = mid
} else {
a = mid
a = mid + 1
}
}
return current.NumberU64() - a + 1
return current.NumberU64() - a
}