Fix docker-compose.yml.
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
reviewed
Jan 8, 2024
| @@ -28,13 +36,15 @@ services: | |||
| depends_on: | |||
| create-beacon-chain-genesis: | |||
| condition: service_completed_successfully | |||
| geth-remove-db: | |||
| condition: service_completed_successfully | |||
There was a problem hiding this comment.
Would this remove the geth db on any restart? I'm worried that people people will unwittingly delete databases they care about across restarts.
There was a problem hiding this comment.
+1 here. Although, not even sure if the system works if you turn it off and restart it after a long time. Worth checking if so
There was a problem hiding this comment.
Oh nm, this only removes the existing db when we generate a new geth genesis. Ignore my other comment.
rauljordan
approved these changes
Jan 8, 2024
0xWilliamWang
pushed a commit
to 0xWilliamWang/geth-prysm-optimism-rollup-dmeo
that referenced
this pull request
Sep 12, 2024
Fix `docker-compose.yml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix prysmaticlabs/prysm#13330.