Fix race between prysmctl and geth genesis #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
May 2, 2023
0xWilliamWang
pushed a commit
to 0xWilliamWang/geth-prysm-optimism-rollup-dmeo
that referenced
this pull request
Sep 12, 2024
Fix race between prysmctl and geth genesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If geth initializes genesis before prysmctl completes, it will most likely startup with the a shanghai fork timestamp in the past, causing it to ignore beacon node FCU from bellatrix and creating a split between the two services. This change makes a service order dependency between
geth-genesisandcreate-beacon-chain-genesisto make sure all services see the same relative timestamps.