Thread safety fixes to address potential crashes and freezes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campbellwmorgan
approved these changes
Feb 6, 2023
|
@millenium-cyborg We've just been doing some QA on this and have found that the Spout Output now causes OBS to crash on exit. To recreate:
|
|
@millenium-cyborg good news - our internal QA shows that this is working well now! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits clean up the locking strategy in spout-output and spout-filter, fixing a number of freezes, crash on exit, and similar errors due to race conditions between the OBS main and graphics threads.
The create/destroy methods are also tidied up and no longer have a potential null pointer dereference.
Bonus: made the filter actually stop sending if it's disabled in OBS.
Maintainer Edit