Use SendTexture to lower the overhead of the spout filter #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campbellwmorgan
requested changes
Sep 13, 2022
There was a problem hiding this comment.
Hi, Thank you so much for this contribution. I've tested locally and it's working really well.
If you have time, do you think you could rebase this on top of the latest master (the OBS v. 28 release)?
I have rebased it myself locally and it works very well on OBS 28, so don't feel you need to go through the pain of updating your local dev environment to 28 to test it (at least it was a pain for me). In any case, before releasing it we will thoroughly QA it.
Many thanks again!
y2kcyborg
force-pushed
the
spout-sendtexture
branch
from
d010fc5 to
5f5e862
Compare
|
Thanks for taking a look! I've tidied up and rebased as you asked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes replace some GPU->CPU and CPU->GPU copies with on-GPU copies and conversions, lowering the overhead of the spout filter and hopefully addressing #42 . In my test setup the render time went from around 5.5ms to 0.3ms with two spout filters active.
I've fixed the issues I found in my own limited testing, but others may remain. There may also be further improvements possible to the rendering.
Anecdotally, this might also resolve a crash on exit when using the spout filter, although I can't reproduce it 100% on
master.