Implement Peeks #49
Merged
Implement Peeks #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coax1d
approved these changes
Mar 22, 2023
added 11 commits
September 26, 2023 15:54
This only makes the variable names match the contents. It does not change behavior in any way.
The transactions encode differently now becuase there is a Vec of peeks in it. Even if there are no peeks (like all of the pre-existing tests) the encoding still chenges because a Vec's encoding contains it's length, so even an empty (length-of-zero) Vec still inserts a byte into the encoding.
I'm not sure what "some reason" was, but `cargo fmt` seems to be working fine for me.
|
TODO I believe the wallet still needs updated. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the peek functionality for reading state without consuming it as described in the original grant proposal.
This will help facilitate concurrency down the road. Even before that, it makes it nice that you can read state without re-writing it and therefore changing its
OutputRef.