-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve CI tests #157
improve CI tests #157
Conversation
I'm open to going this route if it is necessary. But I have some hesitations.
|
True to a certain extent, since it is like a code function we call from multiple sources. It has been made just to avoid copy-pasting the same thing over and over again.
Well,
Sorry if this wasn't clear, but this PR goes in an opposite direction: since we know where the problem with compile time and testing is, we make sure that everything else works and is tested as expected, otherwise we might overlook on some things and introduce bugs or other issues, or forget to test something because we don't check the coverage. |
Okay, I'm coming around to this more and more.
Damn. I didn't realize that. That is a loss and I hope the community carries on that work somehow. I've found it very useful. My point wasn't so much that we need to use that specific thing. My point was that I want the CI to be simple, straight-forward, idiomatic, etc. As opposed to custom, complex, hard-to-understand, etc. We aren't CI experts (at least I'm not) and I don't really want to be one. I just want something simple that tells me if the tests pass. That's what I meant when I was talking about those actions-res examples. I got the rocks-db dependency removed again over in #156 and I thought maybe that would save us enough disk space to not need this. But it wasn't enough. |
We might try to test parachain with the |
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
superseded by #159 |
This PR introduces a custom action to run tests for different crates, and updates the workflow to use this action for testing:
tuxedo-core
;tuxedo-parachain-core
andparachain-piece
, which is currently skipped as it fails because it uses too much disk space;tuxedo-template-runtime
, which I think we could skip entirely;This PR is a step towards #155.