Conversation
Console/Command/QueueShell.php
Outdated
| * @param string|null $param String to convert | ||
| * @return array | ||
| */ | ||
| protected function _stringToArray($param): array { |
| } | ||
|
|
||
| /** | ||
| * |
| } | ||
|
|
||
| /** | ||
| * |
| $conditions[$key . ' IN'] = $include; | ||
| } | ||
| if ($exclude) { | ||
| $conditions[$key . ' NOT IN'] = $exclude; |
There was a problem hiding this comment.
I don't think the IN and NOT IN are needed
There was a problem hiding this comment.
I think this may have been done on purpose. If $conditions['NOT'] is added here, there's a greater chance it would be overwritten by the calling function. Not too clean, though
|
It's not building. Any idea why? |
Build still failing. Seen this before? +++curl -sSL -K /home/travis/.github-headers https://api.github.com/repos/cakephp/cakephp/git/refs/heads |
Codecov Report
@@ Coverage Diff @@
## 2.x #36 +/- ##
============================================
- Coverage 75.62% 70.86% -4.77%
- Complexity 66 76 +10
============================================
Files 5 5
Lines 279 302 +23
============================================
+ Hits 211 214 +3
- Misses 68 88 +20
Continue to review full report at Codecov.
|
This change allows us to move tasks to a new server. Code was backported from the 3.x branch.