Skip to content

Filter tasks by task name#36

Merged
tersmitten merged 8 commits intoOefenweb:2.xfrom
notpron:2.x-task-type-filter
Aug 6, 2019
Merged

Filter tasks by task name#36
tersmitten merged 8 commits intoOefenweb:2.xfrom
notpron:2.x-task-type-filter

Conversation

@notpron
Copy link

@notpron notpron commented Jul 18, 2019

This change allows us to move tasks to a new server. Code was backported from the 3.x branch.

* @param string|null $param String to convert
* @return array
*/
protected function _stringToArray($param): array {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string $param = null

}

/**
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing doc-comment

}

/**
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing doc-comment

$conditions[$key . ' IN'] = $include;
}
if ($exclude) {
$conditions[$key . ' NOT IN'] = $exclude;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the IN and NOT IN are needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may have been done on purpose. If $conditions['NOT'] is added here, there's a greater chance it would be overwritten by the calling function. Not too clean, though

@tersmitten
Copy link
Member

It's not building. Any idea why?

@tersmitten tersmitten added this to the 2.1.0 milestone Jul 19, 2019
@notpron
Copy link
Author

notpron commented Jul 24, 2019

It's not building. Any idea why?

Build still failing. Seen this before?

+++curl -sSL -K /home/travis/.github-headers https://api.github.com/repos/cakephp/cakephp/git/refs/heads
++BRANCH='{
"message": "API rate limit exceeded for 34.66.178.120. (But here'''s the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
"documentation_url": "https://developer.github.com/v3/#rate-limiting"
}'
+++echo '{
"message": "API rate limit exceeded for 34.66.178.120. (But here'''s the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
"documentation_url": "https://developer.github.com/v3/#rate-limiting"
}'

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #36 into 2.x will decrease coverage by 4.76%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x      #36      +/-   ##
============================================
- Coverage     75.62%   70.86%   -4.77%     
- Complexity       66       76      +10     
============================================
  Files             5        5              
  Lines           279      302      +23     
============================================
+ Hits            211      214       +3     
- Misses           68       88      +20
Impacted Files Coverage Δ Complexity Δ
Model/QueuedTask.php 78.57% <18.75%> (-11.91%) 25 <13> (+6)
Console/Command/QueueShell.php 64.77% <27.27%> (-2.3%) 46 <3> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68abc3...39b58fa. Read the comment docs.

@tersmitten tersmitten merged commit e07aef6 into Oefenweb:2.x Aug 6, 2019
@notpron notpron deleted the 2.x-task-type-filter branch May 4, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants