Don't sort config. Respect the original order

[pescobar]

while testing the role I realized if I define this varible:

netplan_conf: |
  network:
    version: {{ netplan_version }}
    renderer: {{ netplan_renderer }}
    ethernets:
      eth0:
        addresses:
        - 10.34.46.100/24
      ens19:
        addresses:
        - 192.168.2.2/24
      ens20:
        addresses:
        - 192.168.3.2/24

I get this config (different order)

network:
  ethernets:
    ens19:
      addresses:
      - 192.168.2.2/24
    ens20:
      addresses:
      - 192.168.3.2/24
    eth0:
      addresses:
      - 10.34.46.100/24
  renderer: networkd
  version: 2

With this PR the generated config respects the same order defined in the ansible var e.g.

#
# Ansible managed
#
---
network:
  version: 2
  renderer: networkd
  ethernets:
    eth0:
      addresses:
      - 10.34.46.100/24
    ens19:
      addresses:
      - 192.168.2.2/24
    ens20:
      addresses:
      - 192.168.3.2/24

[tersmitten]

Isn't it a bit tricky to assume "a dict" to be ordered?

And does it affect the behavior of the role?

[pescobar]

As far as I know it doesn't affect the behavior of the role, it's just a matter of convenience from an operator point of view.

Personally I like to define physical interfaces at the top and then logical interfaces (e.g. bond and vlans) at the bottom. I also find convenient that the deployed config file is a 1 to 1 copy of the config defined in netplan_conf and avoid sorting it alphabetically by key (as it happens now). This simplifies debugging or updating an existing config, at least for me.

Feel free to discard the PR if you think it's not useful.

thanks for publishing the role :)

[tersmitten]

I understand what you mean, but I'm not sure that if you disable sorting that you'll get the same order every time (in all Python versions). At least time has been an issue with Dict's in Python.