Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: omitempty standard change template #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: omitempty standard change template #220

wants to merge 1 commit into from

Conversation

susanpann
Copy link
Contributor

tothegills
tothegills reviewed Nov 14, 2023
View reviewed changes
pkg/projects/servicenow_extension_settings.go
IsStateAutomaticallyTransitioned bool
StandardChangeTemplateName string
IsStateAutomaticallyTransitioned bool `json:"AutomaticStateTransition"`
StandardChangeTemplateName string `json:"StandardChangeTemplateName,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe how this relates to the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a required change, but I thought to add the omitempty to mimic what the UI does when sending the request. ie. If the standard template name isn't provided it leaves that field out of the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothegills tothegills tothegills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susanpann @tothegills