Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting projects to new msbuild #22

Merged
merged 13 commits into from
Apr 20, 2017
Merged

Converting projects to new msbuild #22

merged 13 commits into from
Apr 20, 2017

Conversation

johnsimons
Copy link
Contributor

Had a go at doing the conversion, not sure what I missed!

@droyad can you review this ?

@droyad
Copy link
Contributor

droyad commented Mar 30, 2017

I'd expect changes to the sln file, the tests and build. Did you have a look at this PR?OctopusDeploy/Halibut#31

@johnsimons
Copy link
Contributor Author

I will @droyad, thanks

@johnsimons johnsimons force-pushed the convert-to-new-msbuild branch from 724c78e to 856d8c5 Compare April 5, 2017 06:36
@johnsimons
Copy link
Contributor Author

@droyad @slewis74 @alfhenrik this should now be complete.
I have upgraded the cake build script.
I have updated some dependencies.

The test projects need to be net452 now because for xunit2 that is the minimum.

@johnsimons
Copy link
Contributor Author

For some reason the build server doesn't seem to have any compatible agent!

@matt-richardson
Copy link
Contributor

@johnsimons I changed the agent requirements to agentType = Build-VS2017, and its now kicked building.

@johnsimons
Copy link
Contributor Author

Thanks @matt-richardson

So it looks like TC is looking in C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Sdks\Microsoft.NET.Sdk\Sdk\ instead of C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0

@johnsimons
Copy link
Contributor Author

This is the issue https://developercommunity.visualstudio.com/content/problem/25594/visual-studio-build-tools-2017-is-missing-msbuild.html

@droyad
Copy link
Contributor

droyad commented Apr 6, 2017

Sorry, just saw this convo. We should be using the DotNetCore tooling to build these projects, then VS 2017 isn't needed, same as Halibut. Pushed up the changes in the build file, and it looks good now.

@johnsimons
Copy link
Contributor Author

@droyad Any idea why NUnit report is still being used - https://build.octopushq.com/viewLog.html?buildId=189335&buildTypeId=OctopusDeploy_LIbraries_Nevermore&tab=buildLog#_focus=104 ?

@johnsimons
Copy link
Contributor Author

@droyad regarding using DotNetCore I guess we have to for now, but in the future MS is getting rid of it, msbuild for everything, so we need to fix our agents

@droyad
Copy link
Contributor

droyad commented Apr 6, 2017 •
edited
Loading

I don't believe that is the case, link? dotnet is here to stay. They have just done an awful amount of work to get dotnet to work with the new project system.

@johnsimons
Copy link
Contributor Author

That is not my understanding hence the move to csproj vs project.json, and msbuild.exe vs dotnet.exe and even ms converting msbuild to multi plat. anyway I think for now we are safe

@johnsimons
Copy link
Contributor Author

So do we disable the nunit test reporter in TC feature ?

Merge remote-tracking branch 'origin/master' into convert-to-new-msbuild
5bff94c 
# Conflicts:
#	source/Nevermore.IntegrationTests/RelationalTransaction/LoadFixture.cs
#	source/Nevermore.IntegrationTests/project.json
#	source/Nevermore.Tests/QueryBuilderFixture/QueryBuilderFixture.cs
@johnsimons johnsimons merged commit 720a346 into master Apr 20, 2017
@johnsimons johnsimons deleted the convert-to-new-msbuild branch April 20, 2017 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droyad droyad droyad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnsimons @droyad @matt-richardson @slewis74