Skip to content

node 20, add blocking parameter, add tests #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
cache: 'npm'
cache-dependency-path: 'automagicallyexecute/package-lock.json'

Expand All @@ -30,6 +30,10 @@ jobs:
run: npm run build
working-directory: "automagicallyexecute/"

- name: prune
run: npm prune --omit=dev
working-directory: "automagicallyexecute/"

- name: install tfx
run: npm add -g tfx-cli

Expand All @@ -45,7 +49,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
cache: 'npm'
cache-dependency-path: 'automagicallyexecute/package-lock.json'

Expand All @@ -56,3 +60,24 @@ jobs:
- name: lint
run: npm run lint
working-directory: "automagicallyexecute/"

test:
runs-on: ubuntu-latest
name: testing
steps:
- name: Checkout
uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: 20
cache: 'npm'
cache-dependency-path: 'automagicallyexecute/package-lock.json'

- name: install dependencies
run: npm ci
working-directory: "automagicallyexecute/"

- name: lint
run: npm run test
working-directory: "automagicallyexecute/"
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
cache: 'npm'
cache-dependency-path: 'automagicallyexecute/package-lock.json'

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
v20
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,15 @@ See the [docs](https://octomind.dev/docs) for more details.
url: <publicly accessible url to your deployment>
token: ${{ secrets.AUTOMAGICALLY_TOKEN }}
testTargetId: <your testTargetId that you also get from us>
blocking: <if your pipeline should block until all tests have passed, defaults to false>
```

By default the task will run a maximum duration of 2 hours before it will fail with a timeout.

## Change Log

- 2023-07-23: Added requirement for setting `testTargetId` to enable v2 API
- 2024-10-18: Added blocking parameter to allow blocking your pipeline until all tests have passed.

## Publishing notes

Expand Down
30 changes: 25 additions & 5 deletions automagicallyexecute/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,39 @@
{
"plugins": ["@typescript-eslint"],
"extends": ["plugin:github/recommended"],
"plugins": [
"@typescript-eslint"
],
"extends": [
"plugin:github/recommended"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "./tsconfig.json"
"project": "./tsconfig.lint.json"
},
"env": {
"node": true,
"jest": true
},
"ignorePatterns": ["node_modules"],
"ignorePatterns": [
"node_modules"
],
"rules": {
"i18n-text/no-en": "off",
"@typescript-eslint/no-floating-promises": "warn",
"prettier/prettier": "warn",
"no-console": "warn"
"no-console": "warn",
"filenames/match-regex": "off"
},
"settings": {
"import/parsers": {
"@typescript-eslint/parser": [
".ts",
".tsx"
]
},
"import/resolver": {
"typescript": {
"alwaysTryTypes": true
}
}
}
}
107 changes: 0 additions & 107 deletions automagicallyexecute/index.ts

This file was deleted.

Loading