Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/contributing md #20

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

LaraKraemer
Copy link
Contributor

Describe your changes

I added the commit rules to the CONTRIBUTING.md file, which follow the general commit standards.

Issue ticket number and link

fixes #1

Checklist before requesting a review

  • I have performed a self-review of the modified docs
  • I have followed the guidelines in the Contributing document.
  • I have added / updated documents (for bug fixes / features).

Copy link
Contributor

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .github/pull_request_template.md from this PR.

@LaraKraemer
Copy link
Contributor Author

LaraKraemer commented Oct 18, 2024

Thanks for pointing this out, sry. I just updated the PR. I noticed there is a conflict in .github/pull_request_template.md. Could you help resolve it or let me know how you'd like me to handle it?

@LaraKraemer LaraKraemer requested a review from A91y October 18, 2024 08:12
@A91y
Copy link
Contributor

A91y commented Oct 22, 2024

@LaraKraemer can you please fix the conflicts, it's ready to be merged.

@LaraKraemer
Copy link
Contributor Author

I fixed the conflicts @A91y

Copy link
Contributor

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review in process

@A91y A91y self-requested a review October 23, 2024 13:45
Copy link
Contributor

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@A91y A91y merged commit 537af12 into Octasol:main Oct 23, 2024
@A91y
Copy link
Contributor

A91y commented Oct 23, 2024

Thanks @LaraKraemer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Add CONTRIBUTING.md
2 participants